[OpInfo] Additional test case for nll_loss #67017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - Added test case with weight and ignore_index both defined to sample_inputs_nll_loss Context: this sample may be important to functorch tests cc @zou3519
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2984129 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
lezcano
approved these changes
Oct 21, 2021
…nll-loss-test-case
zou3519
approved these changes
Oct 21, 2021
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 15, 2022
Edit: OpInfos separated into their own PRs to debug an ASAN failure that doesn't identify the failing test properly. This PR now just updates the out tests.
Adds OpInfos for:
- nn.functional.smooth_l1_loss
- nn.functional.l1_loss
- nn.functional.pdist
- nn.functional.binary_cross_entropy
- nn.functional.triplet_margin_loss
- nn.functional.triplet_margin_with_distance_loss
- nn.functional.max_unpool{1, 2, 3}D
- nn.functional.alpha_dropout
- nn.functional.soft_margin_loss
- nn.functional.multilabel_soft_margin_loss
- nn.functional.multilabel_margin_loss
- nn.functional.multi_margin_loss
- nn.functional.margin_ranking_loss
These OpInfos were taken from #67560, #67823, #68625, and #67079. The sample input update from #67017 is also rolled into this PR.
cc @zou3519 @nikitaved @pmeier @vfdev-5 @dagitses
Pull Request resolved: #75782
Approved by: https://github.com/ngimel
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 16, 2022
Summary:
Edit: OpInfos separated into their own PRs to debug an ASAN failure that doesn't identify the failing test properly. This PR now just updates the out tests.
Adds OpInfos for:
- nn.functional.smooth_l1_loss
- nn.functional.l1_loss
- nn.functional.pdist
- nn.functional.binary_cross_entropy
- nn.functional.triplet_margin_loss
- nn.functional.triplet_margin_with_distance_loss
- nn.functional.max_unpool{1, 2, 3}D
- nn.functional.alpha_dropout
- nn.functional.soft_margin_loss
- nn.functional.multilabel_soft_margin_loss
- nn.functional.multilabel_margin_loss
- nn.functional.multi_margin_loss
- nn.functional.margin_ranking_loss
These OpInfos were taken from #67560, #67823, #68625, and #67079. The sample input update from #67017 is also rolled into this PR.
cc zou3519 nikitaved pmeier vfdev-5 dagitses
Pull Request resolved: #75782
Approved by: https://github.com/ngimel
Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b09769992f83f94150eaef2ab9d03c37b36da159
Reviewed By: mehtanirav
Differential Revision: D35679121
fbshipit-source-id: 931e22585fb843bdc340f58c3fbe7c2bde2c123f
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Closing this PR as it was included in #75782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Context: this sample may be important to functorch tests
cc @zou3519 @lezcano