Move the registration of CPython builtin modules to BuiltinRegistry #67085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 26b1a9b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D31848547 |
|
This pull request was exported from Phabricator. Differential Revision: D31848547 |
PaliC
force-pushed
the
export-D31848547
branch
from
bdd5f90 to
0c23961
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31848547 |
PaliC
force-pushed
the
export-D31848547
branch
from
0c23961 to
bc307de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31848547 |
PaliC
force-pushed
the
export-D31848547
branch
from
bc307de to
00d7c20
Compare
shunting314
requested changes
Oct 22, 2021
There was a problem hiding this comment.
Overall looks pretty good to me!
Just one thing about code structure. Can we put all the registration code for frozenpython to its separate file since it gets bigger? Check an example of how we do that for numpy here
|
This pull request was exported from Phabricator. Differential Revision: D31848547 |
PaliC
force-pushed
the
export-D31848547
branch
from
00d7c20 to
6be217a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31848547 |
PaliC
force-pushed
the
export-D31848547
branch
from
6be217a to
a738255
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31848547 |
PaliC
force-pushed
the
export-D31848547
branch
from
a738255 to
1bfaf05
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31848547 |
PaliC
force-pushed
the
export-D31848547
branch
from
1bfaf05 to
584d7d6
Compare
…ytorch#67085) Summary: Pull Request resolved: pytorch#67085 leverages BuiltinRegistry to register the CPython standard C modules. The standard C modules moved are in the FOR_EACH macro Test Plan: buck test mode/opt //caffe2/torch/csrc/deploy/interpreter:test_builtin_registry buck test mode/opt //caffe2/torch/csrc/deploy:test_deploy Differential Revision: D31848547 fbshipit-source-id: 9e33d0c0a350cf62467ba3b1efea3dda685d392e
|
This pull request was exported from Phabricator. Differential Revision: D31848547 |
PaliC
force-pushed
the
export-D31848547
branch
from
584d7d6 to
26b1a9b
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 25, 2021
…67085) Summary: Pull Request resolved: #67085 leverages BuiltinRegistry to register the CPython standard C modules. The standard C modules moved are in the FOR_EACH macro Test Plan: buck test mode/opt //caffe2/torch/csrc/deploy/interpreter:test_builtin_registry buck test mode/opt //caffe2/torch/csrc/deploy:test_deploy Reviewed By: shunting314 Differential Revision: D31848547 fbshipit-source-id: 7eb49d222eaaccb2b8ca5c984b05bf54cc233f25
langong347
pushed a commit
that referenced
this pull request
Oct 25, 2021
…67085) Summary: Pull Request resolved: #67085 leverages BuiltinRegistry to register the CPython standard C modules. The standard C modules moved are in the FOR_EACH macro Test Plan: buck test mode/opt //caffe2/torch/csrc/deploy/interpreter:test_builtin_registry buck test mode/opt //caffe2/torch/csrc/deploy:test_deploy Reviewed By: shunting314 Differential Revision: D31848547 fbshipit-source-id: 7eb49d222eaaccb2b8ca5c984b05bf54cc233f25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: leverages BuiltinRegistry to register the CPython standard C modules. The standard C modules moved are in the FOR_EACH macro
Test Plan:
buck test mode/opt //caffe2/torch/csrc/deploy/interpreter:test_builtin_registry
buck test mode/opt //caffe2/torch/csrc/deploy:test_deploy
Differential Revision: D31848547