[skip-ci] .github: Set linux gpu instances to be non-ephemeral #67345
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was hitting capacity issues, setting these to non-ephemeral would mean keeping the current capacity at the expense of "unclean" nodes Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
requested review from
driazati,
janeyx99 and
zhouzhuojie
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 31f5b10 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
langong347
reviewed
Oct 27, 2021
Current support is only for linux instances, we can expand support to windows instances if we deem it necessary later on down the line |
malfet
approved these changes
Oct 27, 2021
|
Plz consider adding |
seemethere
changed the title
langong347
approved these changes
Oct 27, 2021
|
@seemethere merged this pull request in 0101b1e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Was hitting capacity issues, setting these to non-ephemeral would mean
keeping the current capacity at the expense of "unclean" nodes
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Differential Revision: D31965477