Fix test_init_pg_and_rpc_with_same_socket by retrying on addr in use error #67638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error [ghstack-poisoned]
H-Huang
requested review from
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2cfac11 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
|
@H-Huang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mrshenli
approved these changes
Nov 1, 2021
|
Looking into other tests that use |
…ddr in use error" Fixes #66983 There is a possibility that the port retrieved from `find_free_port()` becomes unavailable in the between the time that it is retrieved and used by `init_process_group` and `init_rpc`. Example flaky test failure, https://github.com/pytorch/pytorch/runs/3954935266. Added the `retry_on_connect_failures` (https://github.com/pytorch/pytorch/blob/master/torch/testing/_internal/common_utils.py#L2241-L2266) decorator to retry the function on the `Address already in use` error. cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @SciPioneer @H-Huang Differential Revision: [D32074698](https://our.internmc.facebook.com/intern/diff/D32074698) [ghstack-poisoned]
|
@H-Huang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #66983
There is a possibility that the port retrieved from
find_free_port()becomes unavailable in the between the time that it is retrieved and used byinit_process_groupandinit_rpc. Example flaky test failure, https://github.com/pytorch/pytorch/runs/3954935266. Added theretry_on_connect_failures(https://github.com/pytorch/pytorch/blob/master/torch/testing/_internal/common_utils.py#L2241-L2266) decorator to retry the function on theAddress already in useerror.cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @SciPioneer @H-Huang
Differential Revision: D32074698