[SR] Enforce checks for resizing of the internal buffer in MemoryPlanner in unit tests #67941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8a9177e (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: jit
|
This pull request was exported from Phabricator. Differential Revision: D32196204 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D32196204 |
hlu1
force-pushed
the
export-D32196204
branch
from
d28f16d to
a6a013c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32196204 |
hlu1
force-pushed
the
export-D32196204
branch
from
a6a013c to
f966b9a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32196204 |
hlu1
force-pushed
the
export-D32196204
branch
from
f966b9a to
0f3d73a
Compare
…ner in unit tests (pytorch#67941) Summary: Pull Request resolved: pytorch#67941 I just found out that due to the round up of the Tensor storage sizes to multiples of 64 bytes, resizing is not actually triggered for a lot of our unit tests (23 OSS, 16 internal). Now they should be all fixed. Also moved a bunch of tests to `test_static_module.cc` so that `test_static_runtime.cc` now only contains operator tests. From now on, by default if `args2` is passed to `test_static_runtime`, at the end of the second iteration, it would check that the managed buffer's size is bigger than the previous size and enforce that. You can bypass the check for ops with constant output sizes, such as `aten::sum` without `dim` passed in. Test Plan: Facebook ``` buck test //caffe2/benchmarks/static_runtime:static_runtime_cpptest buck test //caffe2/benchmarks/static_runtime/fb:test_fb_operators ``` Reviewed By: swolchok Differential Revision: D32196204 fbshipit-source-id: dc8fb0200c5613406995b072a1b324f781f8fe30
|
This pull request was exported from Phabricator. Differential Revision: D32196204 |
hlu1
force-pushed
the
export-D32196204
branch
from
0f3d73a to
8a9177e
Compare
|
This pull request has been merged in 1b2a366. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I just found out that due to the round up of the Tensor storage sizes to multiples of 64 bytes, resizing is not actually triggered for a lot of our unit tests (23 OSS, 16 internal). Now they should be all fixed. Also moved a bunch of tests to
test_static_module.ccso thattest_static_runtime.ccnow only contains operator tests.From now on, by default if
args2is passed totest_static_runtime, at the end of the second iteration, it would check that the managed buffer's size is bigger than the previous size and enforce that. You can bypass the check for ops with constant output sizes, such asaten::sumwithoutdimpassed in.Test Plan:
Facebook
Differential Revision: D32196204