.github: Refactor GHA linux binary builds #68388
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 01d31a2 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
|
This PR depends on pytorch/builder#904 |
seemethere
added
ciflow/binaries
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
seemethere
changed the title
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later TODO: * Create follow up PR to enable nightly linux GHA builds / disable CircleCI nighlty linux builds Signed-off-by: Eli Uriegas <eliuriegasfb.com> Differential Revision: [D33462294](https://our.internmc.facebook.com/intern/diff/D33462294) [ghstack-poisoned]
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
seemethere
commented
Jan 6, 2022
| } | ||
|
|
||
| FULL_PYTHON_VERSIONS = [ | ||
| "3.6", |
There was a problem hiding this comment.
Removing 3.6 from here since we're going to be deprecating it anyways
| CUDA_ARCHES = ["10.2", "11.1", "11.3", "11.5"] | ||
|
|
||
|
|
||
| ROCM_ARCHES = ["4.2", "4.3.1"] |
There was a problem hiding this comment.
Purposefully not adding ROCm 4.1, see #69773
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later TODO: * Create follow up PR to enable nightly linux GHA builds / disable CircleCI nighlty linux builds Signed-off-by: Eli Uriegas <eliuriegasfb.com> Differential Revision: [D33462294](https://our.internmc.facebook.com/intern/diff/D33462294) [ghstack-poisoned]
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later TODO: * Create follow up PR to enable nightly linux GHA builds / disable CircleCI nighlty linux builds Signed-off-by: Eli Uriegas <eliuriegasfb.com> Differential Revision: [D33462294](https://our.internmc.facebook.com/intern/diff/D33462294) [ghstack-poisoned]
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later TODO: * Create follow up PR to enable nightly linux GHA builds / disable CircleCI nighlty linux builds Signed-off-by: Eli Uriegas <eliuriegasfb.com> Differential Revision: [D33462294](https://our.internmc.facebook.com/intern/diff/D33462294) [ghstack-poisoned]
janeyx99
reviewed
Jan 7, 2022
| trigger_actor: str = 'pytorchbot' | ||
| root_job_condition: str = '' | ||
| label_conditions: str = '' | ||
| # Certain jobs might not want to be part of the ciflow/[all,trunk] workflow |
There was a problem hiding this comment.
Shouldn't every job be a part of ciflow/all? I think I'd expect "all" to mean everything
There was a problem hiding this comment.
I think in the case of binary builds we don't necessarily want them as part of ciflow/all. Since they are the most expensive type of workflow we can potentially run
There was a problem hiding this comment.
I agree with that, I'm more concerned that we're adding potential confusion where
ciflow/all -> trunk + scheduled but NOT binaries.
Ideally, people would just use ciflow/trunk instead of ciflow/all most of the time, but this is currently not the case as people have not moved to using ciflow/trunk.
Random idea that popped into mind: what if we remove the ciflow/all trigger entirely and just have ciflow/trunk, ciflow/scheduled, and ciflow/binaries? This'd get rid of that potential confusion but people who are used to ciflow/all would be confused for a hot minute....
For now I agree we shouldn't add it to ciflow/all
There was a problem hiding this comment.
https://fb.quip.com/RcLZAOb9k0qI is relevant here. I think it will let us avoid having to decide which labels map to which jobs. It's just: there is is a label for every workflow. You want that workflow to run, you add that label. No nesting, overlap, or extra semantics.
janeyx99
reviewed
Jan 7, 2022
janeyx99
approved these changes
Jan 7, 2022
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later TODO: * Create follow up PR to enable nightly linux GHA builds / disable CircleCI nighlty linux builds Signed-off-by: Eli Uriegas <eliuriegasfb.com> Differential Revision: [D33462294](https://our.internmc.facebook.com/intern/diff/D33462294) [ghstack-poisoned]
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later TODO: * Create follow up PR to enable nightly linux GHA builds / disable CircleCI nighlty linux builds Signed-off-by: Eli Uriegas <eliuriegasfb.com> Differential Revision: [D33462294](https://our.internmc.facebook.com/intern/diff/D33462294) [ghstack-poisoned]
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Updates the gpu architectures as well as adding a trigger for on_pull_request for the binary build workflows so that we can iterate on this later TODO: * Create follow up PR to enable nightly linux GHA builds / disable CircleCI nighlty linux builds Signed-off-by: Eli Uriegas <eliuriegasfb.com> Differential Revision: [D33462294](https://our.internmc.facebook.com/intern/diff/D33462294) [ghstack-poisoned]
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Updates the gpu architectures as well as adding a trigger for
on_pull_request for the binary build workflows so that we can iterate on
this later
TODO:
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Differential Revision: D33462294