[SR] Fix stack/concat bug #68777
Closed
[SR] Fix stack/concat bug #68777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 6809526 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: jit
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
1f27476 to
3054055
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
3054055 to
e00dadc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
e00dadc to
1e1c8e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
1e1c8e0 to
3673e06
Compare
mikeiovine
force-pushed
the
export-D32604623
branch
from
3673e06 to
8372f69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
8372f69 to
5cb28d9
Compare
mikeiovine
force-pushed
the
export-D32604623
branch
from
5cb28d9 to
656fc3c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
656fc3c to
4bcc9bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
4bcc9bf to
59421a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
59421a8 to
33f8709
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
33f8709 to
8da35ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
8da35ad to
80264dd
Compare
Summary: Pull Request resolved: pytorch#68777 Fixed some cases where negative dimensions were not handled correctly * `_stack_cpu` calls `maybe_wrap_dim`, but `_stack_cpu_out` does not. This is only problematic when `_stack_cpu_out` forwards to the serial kernel: [ref](https://www.internalfb.com/code/fbsource/[1b5af978b48f2e5d308d42b588bde3275869a57b]/fbcode/caffe2/aten/src/ATen/native/TensorShape.cpp?lines=1541-1547). * concat also needs to wrap its dim Test Plan: `buck test caffe2/benchmarks/static_runtime:static_runtime_cpptest` Added new tests to cover this case Reviewed By: hlu1 Differential Revision: D32604623 fbshipit-source-id: 8d3ec171f639b9de3ed66013c364b844051da115
|
This pull request was exported from Phabricator. Differential Revision: D32604623 |
mikeiovine
force-pushed
the
export-D32604623
branch
from
80264dd to
6809526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed some cases where negative dimensions were not handled correctly
_stack_cpucallsmaybe_wrap_dim, but_stack_cpu_outdoes not. This is only problematic when_stack_cpu_outforwards to the serial kernel: ref.Test Plan:
buck test caffe2/benchmarks/static_runtime:static_runtime_cpptestAdded new tests to cover this case
Differential Revision: D32604623