Copy: Re-use existing neg and conj kernel implementations #68949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
This was referenced Nov 27, 2021
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ea43da5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. [ghstack-poisoned]
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. [ghstack-poisoned]
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. [ghstack-poisoned]
anjali411
approved these changes
Dec 1, 2021
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. Differential Revision: [D33064390](https://our.internmc.facebook.com/intern/diff/D33064390) [ghstack-poisoned]
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. Differential Revision: [D33064390](https://our.internmc.facebook.com/intern/diff/D33064390) [ghstack-poisoned]
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. Differential Revision: [D33064390](https://our.internmc.facebook.com/intern/diff/D33064390) [ghstack-poisoned]
… conj kernel implementations" This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. Differential Revision: [D33064390](https://our.internmc.facebook.com/intern/diff/D33064390) [ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Dec 18, 2021
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. ghstack-source-id: 48011f7 Pull Request resolved: pytorch#68949
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. Differential Revision: [D33064390](https://our.internmc.facebook.com/intern/diff/D33064390) [ghstack-poisoned]
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Hey @peterbell10 can you please rebase this stack? |
This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. Differential Revision: [D33064390](https://our.internmc.facebook.com/intern/diff/D33064390) [ghstack-poisoned]
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
wconstab
pushed a commit
that referenced
this pull request
Jan 5, 2022
Summary: Pull Request resolved: #68949 This reuses the existing `neg_kernel` and `conj_kernel` implementations for copy, saving some binary size and compile time. Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33064390 Pulled By: anjali411 fbshipit-source-id: eb0ee94ed3db44ae828ea078ba616365f97a7ff5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This reuses the existing
neg_kernelandconj_kernelimplementations for copy, saving some binary size and compile time.
Differential Revision: D33064390