[JIT] fix static variable initialization order issue #69185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `_fuseFrozenConvAddReluImpl` static variable can be uninitialized before the lambda in frozen_conv_add_relu_fusion_impl.cpp runs. Differential Revision: [D32743371](https://our.internmc.facebook.com/intern/diff/D32743371/) [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c723981 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
facebook-github-bot
added
cla signed
oncall: jit
davidberard98
added a commit
that referenced
this pull request
Dec 1, 2021
the `_fuseFrozenConvAddReluImpl` static variable can be uninitialized before the lambda in frozen_conv_add_relu_fusion_impl.cpp runs. Differential Revision: [D32743371](https://our.internmc.facebook.com/intern/diff/D32743371/) ghstack-source-id: 144402945 Pull Request resolved: #69185
the `_fuseFrozenConvAddReluImpl` static variable can be uninitialized before the lambda in frozen_conv_add_relu_fusion_impl.cpp runs. Differential Revision: [D32743371](https://our.internmc.facebook.com/intern/diff/D32743371/) [ghstack-poisoned]
davidberard98
added a commit
that referenced
this pull request
Dec 1, 2021
Pull Request resolved: #69185 the `_fuseFrozenConvAddReluImpl` static variable can be uninitialized before the lambda in frozen_conv_add_relu_fusion_impl.cpp runs. ghstack-source-id: 144456289 Differential Revision: [D32743371](https://our.internmc.facebook.com/intern/diff/D32743371/)
|
land was failing so I reverted #68149 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
the
_fuseFrozenConvAddReluImplstatic variable can be uninitialized before the lambda in frozen_conv_add_relu_fusion_impl.cpp runs.Differential Revision: D32743371