-
Notifications
You must be signed in to change notification settings - Fork 25.6k
torch/monitor: add pybind #69567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torch/monitor: add pybind #69567
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d9ed3a8 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This pull request was exported from Phabricator. Differential Revision: D32924141 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D32924141 |
e5764c7
to
bd7a366
Compare
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow For more information, please take a look at the CI Flow Wiki. |
This pull request was exported from Phabricator. Differential Revision: D32924141 |
bd7a366
to
fefd9a2
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
fefd9a2
to
e4fca8a
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
e4fca8a
to
9ef93ce
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D32924141 |
b181e34
to
fc730de
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
fc730de
to
8d646a2
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
8d646a2
to
ab06611
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
265c364
to
cc0ea2a
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
cc0ea2a
to
7a60e9a
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
7a60e9a
to
ad69d29
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
ad69d29
to
e798144
Compare
e798144
to
4da8ab8
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D32924141 |
4da8ab8
to
8ea6c13
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
8ea6c13
to
16d761e
Compare
This pull request was exported from Phabricator. Differential Revision: D32924141 |
16d761e
to
2204006
Compare
Summary: Pull Request resolved: pytorch#69567 This exposes torch.monitor events and stats via pybind11 to the underlying C++ implementation. * The registration interface is a tad different since it takes a lambda function in Python where as in C++ it's a full class. * This has a small amount of changes to the counter interfaces since there's no way to create an initializer list at runtime so they now also take a vector. * Only double based stats are provided in Python since it's intended more for high level stats where float imprecision shouldn't be an issue. This can be changed down the line if need arises. ``` events = [] def handler(event): events.append(event) handle = register_event_handler(handler) log_event(Event(type="torch.monitor.TestEvent", timestamp=datetime.now(), metadata={"foo": 1.0})) ``` D32969391 is now included in this diff. This cleans up the naming for events. type is now name, message is gone, and metadata is renamed data. Test Plan: buck test //caffe2/test:monitor //caffe2/test/cpp/monitor:monitor Reviewed By: kiukchung Differential Revision: D32924141 fbshipit-source-id: b9b51b550255de005e199a4818504ddccc5101f6
This pull request was exported from Phabricator. Differential Revision: D32924141 |
2204006
to
d9ed3a8
Compare
Summary:
This exposes torch.monitor events and stats via pybind11 to the underlying C++ implementation.
Test Plan: buck test //caffe2/test:monitor //caffe2/test/cpp/monitor:monitor
Differential Revision: D32924141