[SR] Force sub-blocks to return at least one output #69836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ca1f496 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
facebook-github-bot
added
the
oncall: jit
This was referenced Dec 13, 2021
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
mikeiovine
pushed a commit
that referenced
this pull request
Dec 14, 2021
Pull Request resolved: #69836 It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. ghstack-source-id: 145619933 Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/)
added 2 commits
December 20, 2021 11:19
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
added 9 commits
December 21, 2021 11:32
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
This was referenced Jan 26, 2022
added 3 commits
January 28, 2022 05:10
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. Differential Revision: [D33050420](https://our.internmc.facebook.com/intern/diff/D33050420/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 2, 2022
Summary: Pull Request resolved: #69836 It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. ghstack-source-id: 148186453 Test Plan: Sub-blocks with no return values tested at top of stack Reviewed By: d1jang Differential Revision: D33050420 fbshipit-source-id: 17d9e19fda6431aa9fd0b155131349bac42bc149
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#69836 It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. ghstack-source-id: 148186453 Test Plan: Sub-blocks with no return values tested at top of stack Reviewed By: d1jang Differential Revision: D33050420 fbshipit-source-id: 17d9e19fda6431aa9fd0b155131349bac42bc149 (cherry picked from commit c97fd07)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#69836 It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. ghstack-source-id: 148186453 Test Plan: Sub-blocks with no return values tested at top of stack Reviewed By: d1jang Differential Revision: D33050420 fbshipit-source-id: 17d9e19fda6431aa9fd0b155131349bac42bc149 (cherry picked from commit c97fd07)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#69836 It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. ghstack-source-id: 148186453 Test Plan: Sub-blocks with no return values tested at top of stack Reviewed By: d1jang Differential Revision: D33050420 fbshipit-source-id: 17d9e19fda6431aa9fd0b155131349bac42bc149 (cherry picked from commit c97fd07)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#69836 It is technically possible for the sub-blocks to return zero outputs. This is problematic for `StaticRuntimeBlockRunner`, because it assumes that at least one output is being returned. Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return `None`. ghstack-source-id: 148186453 Test Plan: Sub-blocks with no return values tested at top of stack Reviewed By: d1jang Differential Revision: D33050420 fbshipit-source-id: 17d9e19fda6431aa9fd0b155131349bac42bc149 (cherry picked from commit c97fd07)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It is technically possible for the sub-blocks to return zero outputs. This is problematic for
StaticRuntimeBlockRunner, because it assumes that at least one output is being returned.Rather than slowing down SR with special logic for this corner case, we can simply force these sub-blocks to return
None.Differential Revision: D33050420