Building support for oneDNN v2.5. #69957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
XiaobingSuper
added
the
intel priority
zhuhaozhe
changed the title
jbschlosser
added
the
triaged
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 400d075 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
zhuhaozhe
force-pushed
the
MLKDNN-DNNL
branch
from
1c7a836 to
cebed90
Compare
|
@VitalyFedyunin This is the PR for filling the compatibility gap of build with oneDNN v2.5. A separate PR (that depends on this PR) will be submitted with ideep/oneDNN upgrade to v2.5. |
|
This PR's commits have been included in #71546. It can be closed. @zhuhaozhe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oneAPI Deep Neural Network Library (previously known as Intel(R) Math Kernel Library for Deep Neural Networks (Intel(R) MKL-DNN) and Deep Neural Network Library (DNNL)) will only accept building or runtime flags which start with "DNNL_" from version v2.5.
This PR is a minimized PR to un-block oneDNN v2.5 building with PyTorch. We only solve building flag compatibility in this PR and keep the user flag like "USE_MKLDNN" "MKLDNN_CPU_RUNTIME" still working as before.
As to the compatibility of runtime flag MKLDNN_VERBOSE, we plan to solve it with an ideep update together with oneDNN v2.5 upgrade. The idea is to set "DNNL_VERBOSE" when ideep is loaded if "MKLDNN_VERBOSE" is set.