-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[NNC Testing] Randomized loop nest infrastructure #70410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: Trying again after #70174 was reverted. Earlier the env variable was read into a static var in C++ causing state to be retained and causing test failures. Static type is removed in this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow For more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7c05721 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
@anijain2305 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Trying again after #70174 was reverted. Earlier the env variable was read into a static var in C++ causing state to be retained and causing test failures. Static type is removed in this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D33321435](https://our.internmc.facebook.com/intern/diff/D33321435) [ghstack-poisoned]
Summary: Trying again after #70174 was reverted. Earlier the env variable was read into a static var in C++ causing state to be retained and causing test failures. Static type is removed in this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d62ede8 Pull Request resolved: #70410
@anijain2305 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Trying again after #70174 was reverted. Earlier the env variable was read into a static var in C++ causing state to be retained and causing test failures. Static type is removed in this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D33321435](https://our.internmc.facebook.com/intern/diff/D33321435) [ghstack-poisoned]
Summary: Trying again after #70174 was reverted. Earlier the env variable was read into a static var in C++ causing state to be retained and causing test failures. Static type is removed in this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 123e205 Pull Request resolved: #70410
@anijain2305 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Stack from ghstack:
Summary: Trying again after #70174 was reverted. Earlier the env
variable was read into a static var in C++ causing state to be retained
and causing test failures. Static type is removed in this PR.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D33321435