linalg.matrix_rank: fix cpp interface + add more overloads
#70575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaved
added
the
module: linear algebra
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1cccbc4 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
lezcano
reviewed
Jan 3, 2022
There was a problem hiding this comment.
This is still missing adding the same functions down below in the file, right? As it stands, these functions are in the detail:: namespace.
pytorch/torch/csrc/api/include/torch/linalg.h
Lines 419 to 426 in 7180582
|
I wonder why do we use the |
|
I wonder just the same. Have not seen it before. |
mruberry
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Looks like this got lost in the shuffle; sorry about that @nikitaved! I'll try and merge this now.
|
@mruberry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 25, 2022
Summary: As per title. cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Pull Request resolved: #70575 Reviewed By: albanD Differential Revision: D33760541 Pulled By: mruberry fbshipit-source-id: e048941311c885f91ae524ab34cb732a18eda6c4
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: As per title. cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Pull Request resolved: pytorch/pytorch#70575 Reviewed By: albanD Differential Revision: D33760541 Pulled By: mruberry fbshipit-source-id: e048941311c885f91ae524ab34cb732a18eda6c4 (cherry picked from commit 2d686e0)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: As per title. cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Pull Request resolved: pytorch/pytorch#70575 Reviewed By: albanD Differential Revision: D33760541 Pulled By: mruberry fbshipit-source-id: e048941311c885f91ae524ab34cb732a18eda6c4 (cherry picked from commit 2d686e0)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: As per title. cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Pull Request resolved: pytorch/pytorch#70575 Reviewed By: albanD Differential Revision: D33760541 Pulled By: mruberry fbshipit-source-id: e048941311c885f91ae524ab34cb732a18eda6c4 (cherry picked from commit 2d686e0)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: As per title. cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Pull Request resolved: pytorch/pytorch#70575 Reviewed By: albanD Differential Revision: D33760541 Pulled By: mruberry fbshipit-source-id: e048941311c885f91ae524ab34cb732a18eda6c4 (cherry picked from commit 2d686e0)
github-actions
bot
deleted the
nikitaved/matrix_rank_missing_interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano