fix CAFFE2_BUILD_MAIN_LIB to the correct C10_BUILD_MAIN_LIB #70848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 74fd1a0 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jan 5, 2022
added 5 commits
January 5, 2022 11:52
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
added 5 commits
January 6, 2022 08:56
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This was referenced Jan 7, 2022
added 20 commits
January 7, 2022 10:07
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Differential Revision: [D33429420](https://our.internmc.facebook.com/intern/diff/D33429420/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 18, 2022
Summary: Pull Request resolved: #70848 This is the C10 library, it that's the main lib we are building here. While here, use `local_defines` instead of `copts` for this definition. Both `copts` and `local_defines` only apply to the compilation units in the library, and not transitively. ghstack-source-id: 146998039 Test Plan: We are relying on CI to verify this doesn't cause any problems. Reviewed By: malfet Differential Revision: D33429420 fbshipit-source-id: b3fc84c0588bd43346e3f9f77e851d293bde9428
This was referenced Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is the C10 library, it that's the main lib we are building
here. While here, use
local_definesinstead ofcoptsfor thisdefinition.
Differential Revision: D33429420