Decprecating routed decoder #70990
Closed
Decprecating routed decoder #70990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 62a0469 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
NivekT
reviewed
Jan 7, 2022
|
|
||
|
|
||
| @functional_datapipe('decode') | ||
| @functional_datapipe('routed_decode') |
There was a problem hiding this comment.
Is there anyone using .decode before? Will this break anything for users?
There was a problem hiding this comment.
I am removing it because no one from domains really uses it 😢
NivekT
approved these changes
Jan 7, 2022
Releasing `decode` API for domains to let them implement custom `decode` DataPipe for now. Differential Revision: [D33477620](https://our.internmc.facebook.com/intern/diff/D33477620) [ghstack-poisoned]
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Releasing
decodeAPI for domains to let them implement customdecodeDataPipe for now.Differential Revision: D33477620