fix python version error #71021
Closed
fix python version error #71021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstalled as python2.7 the test will fail with a syntax issue
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit a8bafd2 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
dagitses
added
the
triaged
albanD
reviewed
Jan 11, 2022
i thought that my more complex version would handle the case that they do not have a python3 alias for python 3 and only "python" which refers to python 3. |
Do you know of any OS that does that? My understanding is that you always get base name (not on all OS to avoid confusion just after 2 removal), major and major.minor binary flavors. |
i do not know of a specific OS off the top of my head where that is the default setup, I just thought that it was a possibility if people have older setups that they have updated overtime in custom ways. If you think it is entirely impossible to occur in a custom setup I do not have any evidence to argue the contrary. I was simply trying to cover all possibilities for safety. I will defer to your judgement on this issue. |
|
Thanks for being careful about that. |
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
Summary: if python3 is the one running the tests but there exists a "python" installed as python2.7 the test will fail with a syntax issue Pull Request resolved: #71021 Reviewed By: zou3519 Differential Revision: D33667073 Pulled By: albanD fbshipit-source-id: 8e489b491439be1740fc32ca5c7cdceb2145771e
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: if python3 is the one running the tests but there exists a "python" installed as python2.7 the test will fail with a syntax issue Pull Request resolved: pytorch/pytorch#71021 Reviewed By: zou3519 Differential Revision: D33667073 Pulled By: albanD fbshipit-source-id: 8e489b491439be1740fc32ca5c7cdceb2145771e (cherry picked from commit 5adfece)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: if python3 is the one running the tests but there exists a "python" installed as python2.7 the test will fail with a syntax issue Pull Request resolved: pytorch/pytorch#71021 Reviewed By: zou3519 Differential Revision: D33667073 Pulled By: albanD fbshipit-source-id: 8e489b491439be1740fc32ca5c7cdceb2145771e (cherry picked from commit 5adfece)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: if python3 is the one running the tests but there exists a "python" installed as python2.7 the test will fail with a syntax issue Pull Request resolved: pytorch/pytorch#71021 Reviewed By: zou3519 Differential Revision: D33667073 Pulled By: albanD fbshipit-source-id: 8e489b491439be1740fc32ca5c7cdceb2145771e (cherry picked from commit 5adfece)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: if python3 is the one running the tests but there exists a "python" installed as python2.7 the test will fail with a syntax issue Pull Request resolved: pytorch/pytorch#71021 Reviewed By: zou3519 Differential Revision: D33667073 Pulled By: albanD fbshipit-source-id: 8e489b491439be1740fc32ca5c7cdceb2145771e (cherry picked from commit 5adfece)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if python3 is the one running the tests but there exists a "python" installed as python2.7 the test will fail with a syntax issue