Remove the dependency of pytorch nightly. #71323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
requested review from
atalman,
janeyx99 and
seemethere
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 89b6015 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Jan 17, 2022
Summary: Strictly speaking, the bisection workflow shouldn't depend on PyTorch nightly: instead, it should install the TorchBench deps after the first time it compiles PyTorch and its domain packages. This PR does this optimization and removes PyTorch nightly dependencies for bisection jobs. So the bisection jobs and OnDemand CI jobs can proceed even if the nightly packages are unavailable. The OnDemand PR CI link is here: pytorch/pytorch#71323. It shows we can run PR CI even without installing nightly packages. Pull Request resolved: #694 Reviewed By: wconstab Differential Revision: D33591716 Pulled By: xuzhao9 fbshipit-source-id: 542928f56c0af16b0a2846813596353bf004c30d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the PyTorch nightly dependencies of TorchBench CI. Instead, it relies on the bisection script to install TorchBench dependencies (pytorch/benchmark#694).
This will unblock TorchBench CI users when the nightly build fails (e.g., #71260)
RUN_TORCHBENCH: resnet18
TORCHBENCH_BRANCH: xz9/optimize-bisection