[PyTorch][Static Runtime] Delete cleanup_activations option #71501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. Differential Revision: [D33669290](https://our.internmc.facebook.com/intern/diff/D33669290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33669290/)! [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8318c77 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
swolchok
added a commit
that referenced
this pull request
Jan 19, 2022
This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. Differential Revision: [D33669290](https://our.internmc.facebook.com/intern/diff/D33669290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33669290/)! ghstack-source-id: 147278926 Pull Request resolved: #71501
facebook-github-bot
added
the
oncall: jit
This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. Differential Revision: [D33669290](https://our.internmc.facebook.com/intern/diff/D33669290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33669290/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 20, 2022
Pull Request resolved: #71501 This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. ghstack-source-id: 147370894 Differential Revision: [D33669290](https://our.internmc.facebook.com/intern/diff/D33669290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33669290/)!
This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. Differential Revision: [D33669290](https://our.internmc.facebook.com/intern/diff/D33669290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33669290/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 21, 2022
Pull Request resolved: #71501 This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. ghstack-source-id: 147385569 Differential Revision: [D33669290](https://our.internmc.facebook.com/intern/diff/D33669290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33669290/)!
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
Summary: Pull Request resolved: #71501 This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. ghstack-source-id: 147385569 Test Plan: CI, rerun broken test from task Reviewed By: mikeiovine Differential Revision: D33669290 fbshipit-source-id: ecb01995891aecb5f4d0da2d9c51eed1f8fe489a
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 21, 2022
Summary: Pull Request resolved: #71501 This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. ghstack-source-id: 147385569 Test Plan: CI, rerun broken test from task Reviewed By: mikeiovine Differential Revision: D33669290 fbshipit-source-id: ecb01995891aecb5f4d0da2d9c51eed1f8fe489a (cherry picked from commit 5e4fefb)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#71501 This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. ghstack-source-id: 147385569 Test Plan: CI, rerun broken test from task Reviewed By: mikeiovine Differential Revision: D33669290 fbshipit-source-id: ecb01995891aecb5f4d0da2d9c51eed1f8fe489a (cherry picked from commit 5e4fefb)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#71501 This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. ghstack-source-id: 147385569 Test Plan: CI, rerun broken test from task Reviewed By: mikeiovine Differential Revision: D33669290 fbshipit-source-id: ecb01995891aecb5f4d0da2d9c51eed1f8fe489a (cherry picked from commit 5e4fefb)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#71501 This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. ghstack-source-id: 147385569 Test Plan: CI, rerun broken test from task Reviewed By: mikeiovine Differential Revision: D33669290 fbshipit-source-id: ecb01995891aecb5f4d0da2d9c51eed1f8fe489a (cherry picked from commit 5e4fefb)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#71501 This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it. ghstack-source-id: 147385569 Test Plan: CI, rerun broken test from task Reviewed By: mikeiovine Differential Revision: D33669290 fbshipit-source-id: ecb01995891aecb5f4d0da2d9c51eed1f8fe489a (cherry picked from commit 5e4fefb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This option disabled the memory planner. Supporting it would require us to add multiple versions of ops that borrow their inputs (because they rely on the memory planner to support that), and I'm not aware of a particular need to continue supporting it.
Differential Revision: D33669290
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!