[BE] Fix FSDP flaky test #71525
Closed
[BE] Fix FSDP flaky test #71525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #71496. Use file init for test as opposed to TCP init which runs into some port racing conditions as seen in the failures for that issue. Differential Revision: [D33676165](https://our.internmc.facebook.com/intern/diff/D33676165/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 62eeee3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
facebook-github-bot
added
cla signed
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Jan 20, 2022
Closes #71496. Use file init for test as opposed to TCP init which runs into some port racing conditions as seen in the failures for that issue. Differential Revision: [D33676165](https://our.internmc.facebook.com/intern/diff/D33676165/) ghstack-source-id: 147300691 Pull Request resolved: #71525
zhaojuanmao
approved these changes
Jan 21, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
Summary: Pull Request resolved: #71525 Closes #71496. Use file init for test as opposed to TCP init which runs into some port racing conditions as seen in the failures for that issue. ghstack-source-id: 147300691 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D33676165 fbshipit-source-id: fcf83f7c7541d3521d3e38481195b0c7cb081691
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 21, 2022
Summary: Pull Request resolved: #71525 Closes #71496. Use file init for test as opposed to TCP init which runs into some port racing conditions as seen in the failures for that issue. ghstack-source-id: 147300691 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D33676165 fbshipit-source-id: fcf83f7c7541d3521d3e38481195b0c7cb081691 (cherry picked from commit ea091c4)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#71525 Closes pytorch/pytorch#71496. Use file init for test as opposed to TCP init which runs into some port racing conditions as seen in the failures for that issue. ghstack-source-id: 147300691 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D33676165 fbshipit-source-id: fcf83f7c7541d3521d3e38481195b0c7cb081691 (cherry picked from commit ea091c4)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#71525 Closes pytorch/pytorch#71496. Use file init for test as opposed to TCP init which runs into some port racing conditions as seen in the failures for that issue. ghstack-source-id: 147300691 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D33676165 fbshipit-source-id: fcf83f7c7541d3521d3e38481195b0c7cb081691 (cherry picked from commit ea091c4)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#71525 Closes pytorch/pytorch#71496. Use file init for test as opposed to TCP init which runs into some port racing conditions as seen in the failures for that issue. ghstack-source-id: 147300691 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D33676165 fbshipit-source-id: fcf83f7c7541d3521d3e38481195b0c7cb081691 (cherry picked from commit ea091c4)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#71525 Closes pytorch/pytorch#71496. Use file init for test as opposed to TCP init which runs into some port racing conditions as seen in the failures for that issue. ghstack-source-id: 147300691 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D33676165 fbshipit-source-id: fcf83f7c7541d3521d3e38481195b0c7cb081691 (cherry picked from commit ea091c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Closes #71496. Use file init
for test as opposed to TCP init which runs into some port racing conditions as
seen in the failures for that issue.
Differential Revision: D33676165