[ONNX] Update opset_version restriction for local function #71619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0b17b8b (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
gchanan
added
the
triaged
garymm
requested changes
Jan 22, 2022
Co-authored-by: Gary Miguel <garymiguel@microsoft.com>
garymm
approved these changes
Jan 26, 2022
|
@pytorchbot merge this |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 27, 2022
Summary: Export should fail if export_modules_as_functions is set and opset_version<15. This is because opeset_version < 15 implies IR version < 8, which means no local function support. Pull Request resolved: #71619 Test Plan: automation Reviewed By: bigfootjon Differential Revision: D33809479 fbshipit-source-id: d0a2307dbd1f7002f43f7c77b372c4e19eabf27d
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Export should fail if export_modules_as_functions is set and opset_version<15. This is because opeset_version < 15 implies IR version < 8, which means no local function support. Pull Request resolved: pytorch/pytorch#71619
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Export should fail if export_modules_as_functions is set and opset_version<15. This is because opeset_version < 15 implies IR version < 8, which means no local function support. Pull Request resolved: pytorch/pytorch#71619
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Export should fail if export_modules_as_functions is set and opset_version<15. This is because opeset_version < 15 implies IR version < 8, which means no local function support. Pull Request resolved: pytorch/pytorch#71619
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Export should fail if export_modules_as_functions is set and opset_version<15. This is because opeset_version < 15 implies IR version < 8, which means no local function support. Pull Request resolved: pytorch/pytorch#71619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export should fail if export_modules_as_functions is set and opset_version<15.
This is because opeset_version < 15 implies IR version < 8, which means no local function support.