[Quant][devs] Changed empty_quantized call for quantized tensor to resize_output #71899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit bfb8de8 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
approved these changes
Feb 2, 2022
|
please make sure lint check succeeds before landing |
i've seen this linting issue in several of my PRs and it appears to have been introduced by someone else as it's an issue attributed to a python file I haven't touched. can I ignore this? |
dzdang
changed the title
…ensor to resize_output" Summary: This PR is part of a series of PRs addressing #54150, related to using dispatcher for calls to quantized backends as opposed to if/else conditionals. This particular PR removes the call to empty_quantized for quantized tensors and substitutes it for resize_output, which works for quantized tensors, based on current understanding. Using the dispatcher for this function was determined to be not practical as it would entail a significant amoutn of duplicate code Differential Revision: [D33809138](https://our.internmc.facebook.com/intern/diff/D33809138) [ghstack-poisoned]
dzdang
added a commit
that referenced
this pull request
Feb 2, 2022
…size_output Summary: This PR is part of a series of PRs addressing #54150, related to using dispatcher for calls to quantized backends as opposed to if/else conditionals. This particular PR removes the call to empty_quantized for quantized tensors and substitutes it for resize_output, which works for quantized tensors, based on current understanding. Using the dispatcher for this function was determined to be not practical as it would entail a significant amoutn of duplicate code ghstack-source-id: b1b1516 Pull Request resolved: #71899
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
…size_output (#71899) Summary: Pull Request resolved: #71899 This PR is part of a series of PRs addressing #54150, related to using dispatcher for calls to quantized backends as opposed to if/else conditionals. This particular PR removes the call to empty_quantized for quantized tensors and substitutes it for resize_output, which works for quantized tensors, based on current understanding. Using the dispatcher for this function was determined to be not practical as it would entail a significant amoutn of duplicate code Differential Revision: D33809138 D33809138 Test Plan: Imported from OSS Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5bacea37356547ceacea4b3f6b0141ac3a223dcf
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
…size_output (#71899) Summary: Pull Request resolved: pytorch/pytorch#71899 This PR is part of a series of PRs addressing pytorch/pytorch#54150, related to using dispatcher for calls to quantized backends as opposed to if/else conditionals. This particular PR removes the call to empty_quantized for quantized tensors and substitutes it for resize_output, which works for quantized tensors, based on current understanding. Using the dispatcher for this function was determined to be not practical as it would entail a significant amoutn of duplicate code Differential Revision: D33809138 D33809138 Test Plan: Imported from OSS Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5bacea37356547ceacea4b3f6b0141ac3a223dcf (cherry picked from commit 3bb82ff3040c9a7905a3cfe8a57c69cfe0721955)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
…size_output (#71899) Summary: Pull Request resolved: pytorch/pytorch#71899 This PR is part of a series of PRs addressing pytorch/pytorch#54150, related to using dispatcher for calls to quantized backends as opposed to if/else conditionals. This particular PR removes the call to empty_quantized for quantized tensors and substitutes it for resize_output, which works for quantized tensors, based on current understanding. Using the dispatcher for this function was determined to be not practical as it would entail a significant amoutn of duplicate code Differential Revision: D33809138 D33809138 Test Plan: Imported from OSS Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5bacea37356547ceacea4b3f6b0141ac3a223dcf (cherry picked from commit 3bb82ff3040c9a7905a3cfe8a57c69cfe0721955)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: This PR is part of a series of PRs addressing #54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR removes the call to empty_quantized for quantized tensors and substitutes
it for resize_output, which works for quantized tensors, based on current understanding.
Using the dispatcher for this function was determined to be not practical as it would entail
a significant amoutn of duplicate code
Differential Revision: D33809138