Skip to content

Conversation

@dzdang
Copy link
Contributor

@dzdang dzdang commented Jan 28, 2022

Stack from ghstack:

Summary: This PR is part of a series of PRs addressing #54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

Differential Revision: D33845919

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 28, 2022

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/603389655fddbb81ed4bb7a4912834c3da3ccaeb/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
linux-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-manywheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk, ciflow/xla ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
windows-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
windows-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
windows-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-bionic-rocm4.5-py3.7 ciflow/linux, ciflow/rocm 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped

dzdang added a commit that referenced this pull request Jan 28, 2022
… empty_like

ghstack-source-id: 761346d
Pull Request resolved: #71990
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 28, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 6debccc (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-bionic-py3.7-clang9 / test (noarch, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-02-04T03:22:53.2375930Z RuntimeError: test_dataloader failed!
2022-02-04T03:22:52.9768691Z Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestSetAffinity-20220204032206.xml
2022-02-04T03:22:52.9775051Z Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestTensorDataset-20220204032206.xml
2022-02-04T03:22:52.9778660Z Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestCustomPinFn-20220204032206.xml
2022-02-04T03:22:52.9782701Z Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestDataLoader2_EventLoop-20220204032206.xml
2022-02-04T03:22:52.9786650Z Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestStringDataLoader-20220204032206.xml
2022-02-04T03:22:53.2369369Z Traceback (most recent call last):
2022-02-04T03:22:53.2369645Z   File "test/run_test.py", line 1114, in <module>
2022-02-04T03:22:53.2372517Z     main()
2022-02-04T03:22:53.2372865Z   File "test/run_test.py", line 1092, in main
2022-02-04T03:22:53.2375587Z     raise RuntimeError(err_message)
2022-02-04T03:22:53.2375930Z RuntimeError: test_dataloader failed!
2022-02-04T03:22:53.5511753Z 
2022-02-04T03:22:53.5512469Z real	12m54.110s
2022-02-04T03:22:53.5512838Z user	7m1.139s
2022-02-04T03:22:53.5513053Z sys	0m45.703s
2022-02-04T03:22:53.5513226Z + cleanup
2022-02-04T03:22:53.5513372Z + retcode=1
2022-02-04T03:22:53.5513536Z + set +x
2022-02-04T03:22:53.5559816Z ##[error]Process completed with exit code 1.
2022-02-04T03:22:53.5592550Z ##[group]Run # Ensure the working directory gets chowned back to the current user
2022-02-04T03:22:53.5593017Z �[36;1m# Ensure the working directory gets chowned back to the current user�[0m

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@dzdang
Copy link
Contributor Author

dzdang commented Jan 28, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

dzdang added a commit that referenced this pull request Jan 28, 2022
…rs in empty_like

ghstack-source-id: 588359f
Pull Request resolved: #71990
dzdang added a commit that referenced this pull request Jan 31, 2022
…rs in empty_like

ghstack-source-id: 4e1b417
Pull Request resolved: #71990
@dzdang
Copy link
Contributor Author

dzdang commented Feb 2, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dzdang dzdang changed the title Separated implementations for quantized & non-quantized tensors in in empty_like [Quant][devs] Separated implementations for quantized & non-quantized tensors in empty_like Feb 2, 2022
…n-quantized tensors in empty_like"

Differential Revision: [D33845919](https://our.internmc.facebook.com/intern/diff/D33845919)

[ghstack-poisoned]
…n-quantized tensors in empty_like"

Summary: This PR is part of a series of PRs addressing #54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

Differential Revision: [D33845919](https://our.internmc.facebook.com/intern/diff/D33845919)

[ghstack-poisoned]
dzdang added a commit that referenced this pull request Feb 2, 2022
… tensors in empty_like

Summary: This PR is part of a series of PRs addressing #54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

ghstack-source-id: 2dcc406
Pull Request resolved: #71990
@dzdang
Copy link
Contributor Author

dzdang commented Feb 2, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…n-quantized tensors in empty_like"

Summary: This PR is part of a series of PRs addressing #54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

Differential Revision: [D33845919](https://our.internmc.facebook.com/intern/diff/D33845919)

[ghstack-poisoned]
dzdang added a commit that referenced this pull request Feb 3, 2022
… tensors in empty_like

Summary: This PR is part of a series of PRs addressing #54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

ghstack-source-id: a6a8ca5
Pull Request resolved: #71990
@dzdang
Copy link
Contributor Author

dzdang commented Feb 3, 2022

@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…n-quantized tensors in empty_like"

Summary: This PR is part of a series of PRs addressing #54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

Differential Revision: [D33845919](https://our.internmc.facebook.com/intern/diff/D33845919)

[ghstack-poisoned]
dzdang added a commit that referenced this pull request Feb 4, 2022
… tensors in empty_like

Summary: This PR is part of a series of PRs addressing #54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

ghstack-source-id: e02cded
Pull Request resolved: #71990
facebook-github-bot pushed a commit that referenced this pull request Feb 4, 2022
… tensors in empty_like (#71990)

Summary:
Pull Request resolved: #71990

This PR is part of a series of PRs addressing #54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

Differential Revision:
D33845919
D33845919

Test Plan: Imported from OSS

Reviewed By: jerryzh168

Pulled By: dzdang

fbshipit-source-id: 52b4a0c0c3010c2c4e069ec354c31462e89a0cba
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

Hey dzdang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/dzdang/22/head branch February 8, 2022 15:17
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 9, 2022
… tensors in empty_like (#71990)

Summary:
Pull Request resolved: pytorch/pytorch#71990

This PR is part of a series of PRs addressing pytorch/pytorch#54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

Differential Revision:
D33845919
D33845919

Test Plan: Imported from OSS

Reviewed By: jerryzh168

Pulled By: dzdang

fbshipit-source-id: 52b4a0c0c3010c2c4e069ec354c31462e89a0cba
(cherry picked from commit f94e437609dbe9ec120304f154357ec6fe1f523b)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 9, 2022
… tensors in empty_like (#71990)

Summary:
Pull Request resolved: pytorch/pytorch#71990

This PR is part of a series of PRs addressing pytorch/pytorch#54150,
related to using dispatcher for calls to quantized backends as opposed to if/else conditionals.
This particular PR separates the calls to quantized & non-quantized backends for empty_like
using a dispatcher.

Differential Revision:
D33845919
D33845919

Test Plan: Imported from OSS

Reviewed By: jerryzh168

Pulled By: dzdang

fbshipit-source-id: 52b4a0c0c3010c2c4e069ec354c31462e89a0cba
(cherry picked from commit f94e437609dbe9ec120304f154357ec6fe1f523b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants