[Pytorch Edge] Fix Custom Class Parser #72153

JacobSzwejbka · 2022-02-01T23:06:22Z

Summary: Forgot that schemas can have types like foo.bar[]

Test Plan: ci and the extra files regenerated in this diff

Reviewed By: tugsbayasgalan

Differential Revision: D33928283

facebook-github-bot · 2022-02-01T23:06:29Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/72153
📄 Preview docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 28cf86d (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-xenial-cuda11.3-py3.7-gcc7 / test (default, 1, 2, linux.4xlarge.nvidia.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-02-02T00:42:46.1426263Z FAIL [0.838s]: tes...s_special_zeta_grad_cuda (__main__.TestCommonCUDA)

2022-02-02T00:42:46.1424094Z     self.assertEqual(supported_dtypes, claimed_supported, msg=msg)
2022-02-02T00:42:46.1424457Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2139, in assertEqual
2022-02-02T00:42:46.1424564Z     msg=msg,
2022-02-02T00:42:46.1424881Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1081, in assert_equal
2022-02-02T00:42:46.1425012Z     raise error_metas[0].to_error()
2022-02-02T00:42:46.1425256Z AssertionError: The supported dtypes for special.polygamma on cuda according to its OpInfo are
2022-02-02T00:42:46.1425583Z         {torch.float16, torch.uint8, torch.bool, torch.float32, torch.int8, torch.float64, torch.int16, torch.int32, torch.int64}, but the detected supported dtypes are set().
2022-02-02T00:42:46.1425924Z         The following dtypes should be removed from the OpInfo: {torch.float16, torch.uint8, torch.bool, torch.float32, torch.int8, torch.float64, torch.int16, torch.int32, torch.int64}.
2022-02-02T00:42:46.1425945Z 
2022-02-02T00:42:46.1426078Z ======================================================================
2022-02-02T00:42:46.1426263Z FAIL [0.838s]: test_dtypes_special_zeta_grad_cuda (__main__.TestCommonCUDA)
2022-02-02T00:42:46.1426525Z ----------------------------------------------------------------------
2022-02-02T00:42:46.1426666Z Traceback (most recent call last):
2022-02-02T00:42:46.1427021Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1753, in wrapper
2022-02-02T00:42:46.1427145Z     method(*args, **kwargs)
2022-02-02T00:42:46.1427508Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
2022-02-02T00:42:46.1427647Z     result = test(self, **param_kwargs)
2022-02-02T00:42:46.1428011Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 753, in test_wrapper
2022-02-02T00:42:46.1428137Z     return test(*args, **kwargs)
2022-02-02T00:42:46.1428493Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 788, in dep_fn
2022-02-02T00:42:46.1428675Z     return fn(slf, *args, **kwargs)

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

pytorch-bot · 2022-02-01T23:06:38Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/JacobSzwejbka/pytorch/blob/2284344d6fdb9156afc9f5fadb6ada3aa44906d8/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`, `ciflow/xla`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-bionic-rocm4.5-py3.7	`ciflow/linux`, `ciflow/rocm`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

facebook-github-bot · 2022-02-01T23:06:53Z

This pull request was exported from Phabricator. Differential Revision: D33928283

Summary: Pull Request resolved: pytorch#72153 Forgot that schemas can have types like foo.bar[] Test Plan: ci and the extra files regenerated in this diff Reviewed By: tugsbayasgalan Differential Revision: D33928283 fbshipit-source-id: 5010e041acde16c09181f058092c5a35de9b4733

facebook-github-bot · 2022-02-02T00:06:35Z

This pull request was exported from Phabricator. Differential Revision: D33928283

Summary: Pull Request resolved: #72153 Forgot that schemas can have types like foo.bar[] Test Plan: ci and the extra files regenerated in this diff Reviewed By: tugsbayasgalan Differential Revision: D33928283 fbshipit-source-id: 810d25f8f7c1dd7c75e149739fc9f59c6eafe3b9

github-actions · 2022-02-02T00:31:22Z

Hey JacobSzwejbka.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: pytorch/pytorch#72153 Forgot that schemas can have types like foo.bar[] Test Plan: ci and the extra files regenerated in this diff Reviewed By: tugsbayasgalan Differential Revision: D33928283 fbshipit-source-id: 810d25f8f7c1dd7c75e149739fc9f59c6eafe3b9 (cherry picked from commit 6fe5e8c)

pytorch-bot bot added the ciflow/default label Feb 1, 2022

facebook-github-bot added the cla signed label Feb 1, 2022

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Feb 1, 2022

facebook-github-bot added the fb-exported label Feb 1, 2022

JacobSzwejbka force-pushed the export-D33928283 branch from 2284344 to 28cf86d Compare February 2, 2022 00:06

pytorchmergebot closed this in a34c17b Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Pytorch Edge] Fix Custom Class Parser #72153

[Pytorch Edge] Fix Custom Class Parser #72153

Uh oh!

JacobSzwejbka commented Feb 1, 2022

Uh oh!

facebook-github-bot commented Feb 1, 2022 •

edited

Loading

Uh oh!

pytorch-bot bot commented Feb 1, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 1, 2022

Uh oh!

facebook-github-bot commented Feb 2, 2022

Uh oh!

github-actions bot commented Feb 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[Pytorch Edge] Fix Custom Class Parser #72153

[Pytorch Edge] Fix Custom Class Parser #72153

Uh oh!

Conversation

JacobSzwejbka commented Feb 1, 2022

Uh oh!

facebook-github-bot commented Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

linux-xenial-cuda11.3-py3.7-gcc7 / test (default, 1, 2, linux.4xlarge.nvidia.gpu) (1/1)

Uh oh!

pytorch-bot bot commented Feb 1, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 1, 2022

Uh oh!

facebook-github-bot commented Feb 2, 2022

Uh oh!

github-actions bot commented Feb 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

facebook-github-bot commented Feb 1, 2022 •

edited

Loading