[ONNX] List of files to consider for mergebot onnx rule #72297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenBao
requested review from
atalman,
janeyx99 and
seemethere
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit cfc9378 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
dagitses
added
the
triaged
garymm
reviewed
Feb 4, 2022
garymm
approved these changes
Feb 4, 2022
|
@malfet please review and import. |
BowenBao
force-pushed
the
bowbao/extend_onnx_rule_files
branch
from
e59de85 to
d9c2b9c
Compare
|
@malfet friendly ping for updates |
malfet
approved these changes
Feb 15, 2022
|
@pytorchbot merge this |
|
Merge failed due to PR 72297 does not match merge rules |
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@malfet please merge |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: #72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb
|
Hey @BowenBao. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 21, 2022
Summary: Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed. List of files below and description: * These files are for converting from IR to ONNX proto. These should be used only for ONNX. ``` "torch/csrc/jit/serialization/export.*", "torch/csrc/jit/serialization/onnx.*", ``` * This file is touched whenever pass signature is updated. ``` "torch/_C/__init__.pyi.in", ``` * These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think. ~~"torch/csrc/jit/python/init.cpp",~~ ~~"torch/csrc/jit/python/script_init.cpp",~~ Update: Bowen will move onnx passes to files under onnx folder. * ~~Touched when need new attr::xxx, or onnx::xxx.~~ ~~"aten/src/ATen/core/interned_strings.h"~~ Update: Nikita will help separate this file. malfet Pull Request resolved: pytorch/pytorch#72297 Reviewed By: H-Huang Differential Revision: D34254666 Pulled By: malfet fbshipit-source-id: 032cfa590cbedf4648b7335fe8f09a2380ab14cb (cherry picked from commit 88653eadbf5b6dfe1f84acec8f1c3256a49f2f68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on past PRs, here is an non-exhaustive list of files to consider for extension. The PR is not meant to be final. Based on feedback and discussion, files could be dropped from the list, or PR could be updated to move code around such that extension is no longer needed.
List of files below and description:
These files are touched whenever pass signature is updated. Somehow it's been convention that onnx passes are also added here, but it could be possible to move them. Let me know what you think.
"torch/csrc/jit/python/init.cpp","torch/csrc/jit/python/script_init.cpp",Update: Bowen will move onnx passes to files under onnx folder.
Touched when need new attr::xxx, or onnx::xxx."aten/src/ATen/core/interned_strings.h"Update: Nikita will help separate this file.
@malfet