Add BUILD_LAZY_CUDA_LINALG option #72306
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs [ghstack-poisoned]
malfet
requested review from
IvanYashchuk,
lezcano and
nikitaved
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5e30c44 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Windows build errors are real |
|
So what happens now when |
IvanYashchuk
reviewed
Feb 4, 2022
When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Differential Revision: [D33992795](https://our.internmc.facebook.com/intern/diff/D33992795) [ghstack-poisoned]
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
IvanYashchuk
added
module: linear algebra
lezcano
reviewed
Feb 4, 2022
There was a problem hiding this comment.
As discussed with @IvanYashchuk , we both agree that it would be good to have a small write-up (perhaps at the top of LinearAlgebraStubs.cpp detailing what are the steps that we need to take to add a new function, and possible problems we may find while doing so.
The comment below shows that, at least by the looks of it, one may find some highly non-trivial cases, and it's not clear to us when may this happen.
When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Differential Revision: [D33992795](https://our.internmc.facebook.com/intern/diff/D33992795) [ghstack-poisoned]
When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Differential Revision: [D33992795](https://our.internmc.facebook.com/intern/diff/D33992795) [ghstack-poisoned]
When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Differential Revision: [D33992795](https://our.internmc.facebook.com/intern/diff/D33992795) [ghstack-poisoned]
When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Differential Revision: [D33992795](https://our.internmc.facebook.com/intern/diff/D33992795) [ghstack-poisoned]
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
malfet
added
the
ciflow/binaries
When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Differential Revision: [D33992795](https://our.internmc.facebook.com/intern/diff/D33992795) [ghstack-poisoned]
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Differential Revision: [D33992795](https://our.internmc.facebook.com/intern/diff/D33992795) [ghstack-poisoned]
When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Differential Revision: [D33992795](https://our.internmc.facebook.com/intern/diff/D33992795) [ghstack-poisoned]
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ngimel
approved these changes
Feb 23, 2022
|
|
||
| #if defined(BUILD_LAZY_CUDA_LINALG) | ||
| namespace cuda { namespace detail { | ||
| struct LinalgDispatch { |
There was a problem hiding this comment.
nit: can you add a comment here that these are old-style dispatches and people shouldn't add to this list, and instead prefer implementing with stubs right away?
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
Summary: Pull Request resolved: #72306 When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33992795 Pulled By: malfet fbshipit-source-id: d1fa351a320659b29754997c20d754e69bfe36c0
malfet
added a commit
that referenced
this pull request
Feb 24, 2022
Summary: Pull Request resolved: #72306 When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33992795 Pulled By: malfet fbshipit-source-id: d1fa351a320659b29754997c20d754e69bfe36c0 (cherry picked from commit d5d6c69)
|
Sorry, reverting as this is the most likely culprit of causing timeouts in our OSS CI slow tests. See https://hud2.pytorch.org/hud/pytorch/pytorch/master/2 |
|
This pull request has been reverted by 3127128. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Feb 25, 2022
Summary: Pull Request resolved: pytorch#72306 When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33992795 Pulled By: malfet fbshipit-source-id: d1fa351a320659b29754997c20d754e69bfe36c0 (cherry picked from commit d5d6c69)
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Feb 26, 2022
Summary: Pull Request resolved: pytorch#72306 When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33992795 Pulled By: malfet fbshipit-source-id: d1fa351a320659b29754997c20d754e69bfe36c0 (cherry picked from commit d5d6c69)
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Mar 1, 2022
Summary: Pull Request resolved: pytorch#72306 When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33992795 Pulled By: malfet fbshipit-source-id: d1fa351a320659b29754997c20d754e69bfe36c0 (cherry picked from commit d5d6c69)
|
This pull request has been reverted by 3127128. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#72306 When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33992795 Pulled By: malfet fbshipit-source-id: d1fa351a320659b29754997c20d754e69bfe36c0 (cherry picked from commit d5d6c69a988b9454538ecd28674206da2541de17)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#72306 When enable, it will generate `torch_cuda_linalg` library, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubs Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33992795 Pulled By: malfet fbshipit-source-id: d1fa351a320659b29754997c20d754e69bfe36c0 (cherry picked from commit d5d6c69a988b9454538ecd28674206da2541de17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
When enable, it will generate
torch_cuda_linalglibrary, which would depend on cusolve and magma and registers dynamic bindings to it from LinearAlgebraStubsDifferential Revision: D33992795