[JIT] Remove warning in conv-add-relu fusion #72441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 6157037 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
davidberard98
added a commit
that referenced
this pull request
Feb 7, 2022
Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. ghstack-source-id: aa771ae Pull Request resolved: #72441
facebook-github-bot
added
the
oncall: jit
eellison
approved these changes
Feb 7, 2022
Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. [ghstack-poisoned]
davidberard98
added a commit
that referenced
this pull request
Feb 7, 2022
Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. ghstack-source-id: 7233682 Pull Request resolved: #72441
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Differential Revision: [D34046350](https://our.internmc.facebook.com/intern/diff/D34046350) [ghstack-poisoned]
davidberard98
added a commit
that referenced
this pull request
Feb 8, 2022
Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. ghstack-source-id: 4905c5f Pull Request resolved: #72441
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Differential Revision: [D34046350](https://our.internmc.facebook.com/intern/diff/D34046350) [ghstack-poisoned]
davidberard98
added a commit
that referenced
this pull request
Feb 8, 2022
Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. ghstack-source-id: 97836af Pull Request resolved: #72441
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: #72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a
|
Hey @davidberard98. |
davidberard98
added
release notes: jit
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 15, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 15, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 15, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 16, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 16, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 21, 2022
Summary: Pull Request resolved: pytorch/pytorch#72441 Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing. This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34046350 Pulled By: davidberard98 fbshipit-source-id: d6a939ada81468025b40ec0a2af67517e4357c1a (cherry picked from commit 21b3dfaf71742b5eb0b632d38cc00a0c226f9c8d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Previousl, if no implementation of conv-add-relu fusion was provided, a warning would be shown. This includes in CPU-only builds, where fusion isn't expected to occur (it's a gpu-only fusion, and only available in GPU builds of pytorch). In CPU-only builds the warning was confusing.
This removes the warning; in the case that the user wants the fusion to occur, they probably already have a pytorch build with gpu support.
Differential Revision: D34046350