[PyTorch] MHA: fix contiguity assumption in transform_bias_rescale_qkv #72465

swolchok · 2022-02-07T21:31:29Z

Stack from ghstack:

This code path incorrectly assumed input tensors were contiguous. Now we check that.

Differential Revision: D34007665

This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

pytorch-bot · 2022-02-07T21:31:33Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/effbe2bced2257c293a184949afc805487d6e1d8/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`, `ciflow/xla`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

facebook-github-bot · 2022-02-07T21:31:45Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/72465
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 4e791e4 (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-02-15T21:39:34.1705008Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m

2022-02-15T21:39:34.1702125Z �[36;1mfi�[0m
2022-02-15T21:39:34.1702364Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-02-15T21:39:34.1702694Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-02-15T21:39:34.1703000Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-02-15T21:39:34.1703335Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-02-15T21:39:34.1703610Z �[36;1m  exit 1�[0m
2022-02-15T21:39:34.1703795Z �[36;1mfi�[0m
2022-02-15T21:39:34.1704063Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-02-15T21:39:34.1704388Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-02-15T21:39:34.1704680Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-02-15T21:39:34.1705008Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-02-15T21:39:34.1705351Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-02-15T21:39:34.1705580Z �[36;1m  exit 1�[0m
2022-02-15T21:39:34.1705728Z �[36;1mfi�[0m
2022-02-15T21:39:34.1705926Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-02-15T21:39:34.1716299Z shell: /usr/bin/bash -e {0}
2022-02-15T21:39:34.1716479Z env:
2022-02-15T21:39:34.1716726Z   BUILD_ENVIRONMENT: linux-xenial-cuda11.3-py3.7-gcc7-bazel-test
2022-02-15T21:39:34.1717116Z   DOCKER_IMAGE_BASE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7
2022-02-15T21:39:34.1717489Z   SCCACHE_BUCKET: ossci-compiler-cache-circleci-v2
2022-02-15T21:39:34.1717810Z   XLA_CLANG_CACHE_S3_BUCKET_NAME: ossci-compiler-clang-cache-circleci-xla

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) ghstack-source-id: 148555659 Pull Request resolved: #72465

…_rescale_qkv" This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

Pull Request resolved: #72465 This code path incorrectly assumed input tensors were contiguous. Now we check that. ghstack-source-id: 148681134 Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/)

…_rescale_qkv" This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

Pull Request resolved: #72465 This code path incorrectly assumed input tensors were contiguous. Now we check that. ghstack-source-id: 148865118 Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/)

…_rescale_qkv" This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

Pull Request resolved: #72465 This code path incorrectly assumed input tensors were contiguous. Now we check that. ghstack-source-id: 149067338 Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/)

…_rescale_qkv" This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

Pull Request resolved: #72465 This code path incorrectly assumed input tensors were contiguous. Now we check that. ghstack-source-id: 149201476 Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/)

#72465) Summary: Pull Request resolved: #72465 This code path incorrectly assumed input tensors were contiguous. Now we check that. ghstack-source-id: 149201476 Test Plan: CI Reviewed By: ngimel Differential Revision: D34007665 fbshipit-source-id: c43438f2495e32304ea3f7846e01eceb4a9448f7

github-actions · 2022-02-16T18:37:29Z

Hey @swolchok.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

…v (#72465) Summary: Pull Request resolved: pytorch/pytorch#72465 This code path incorrectly assumed input tensors were contiguous. Now we check that. ghstack-source-id: 149201476 Test Plan: CI Reviewed By: ngimel Differential Revision: D34007665 fbshipit-source-id: c43438f2495e32304ea3f7846e01eceb4a9448f7 (cherry picked from commit 0767b225f23846c1636ac3622f46b0c5ec071d96)

[PyTorch] MHA: fix contiguity assumption in transform_bias_rescale_qkv

effbe2b

This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

pytorch-bot bot added the ciflow/default label Feb 7, 2022

facebook-github-bot added the cla signed label Feb 7, 2022

Update on "[PyTorch] MHA: fix contiguity assumption in transform_bias…

640ad89

…_rescale_qkv" This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

Update on "[PyTorch] MHA: fix contiguity assumption in transform_bias…

da46a1b

…_rescale_qkv" This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

swolchok mentioned this pull request Feb 10, 2022

[PyTorch] Handle non-vectorizable parameters for native MHA CUDA rescale kernel #72671

Closed

Update on "[PyTorch] MHA: fix contiguity assumption in transform_bias…

18f4303

…_rescale_qkv" This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

Update on "[PyTorch] MHA: fix contiguity assumption in transform_bias…

c51d753

…_rescale_qkv" This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

Update on "[PyTorch] MHA: fix contiguity assumption in transform_bias…

4e791e4

…_rescale_qkv" This code path incorrectly assumed input tensors were contiguous. Now we check that. Differential Revision: [D34007665](https://our.internmc.facebook.com/intern/diff/D34007665/) [ghstack-poisoned]

pytorchmergebot closed this in 41ad221 Feb 16, 2022

facebook-github-bot deleted the gh/swolchok/453/head branch February 20, 2022 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PyTorch] MHA: fix contiguity assumption in transform_bias_rescale_qkv #72465

[PyTorch] MHA: fix contiguity assumption in transform_bias_rescale_qkv #72465

Uh oh!

swolchok commented Feb 7, 2022 •

edited

Loading

Uh oh!

pytorch-bot bot commented Feb 7, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 7, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Feb 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[PyTorch] MHA: fix contiguity assumption in transform_bias_rescale_qkv #72465

[PyTorch] MHA: fix contiguity assumption in transform_bias_rescale_qkv #72465

Uh oh!

Conversation

swolchok commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Feb 7, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Uh oh!

github-actions bot commented Feb 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

swolchok commented Feb 7, 2022 •

edited

Loading

facebook-github-bot commented Feb 7, 2022 •

edited

Loading