only compare attributes for meta tensors #72508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 877f3f9 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
added
module: testing
Todo: - [ ] document this behavior - [ ] add tests [ghstack-poisoned]
Todo: - [ ] document this behavior - [x] add tests [ghstack-poisoned]
Todo: - [ ] document this behavior - [x] add tests [ghstack-poisoned]
Todo: - [ ] document this behavior - [x] add tests [ghstack-poisoned]
pmeier
commented
Feb 9, 2022
| # https://github.com/pytorch/pytorch/issues/67517 | ||
| DecorateInfo(unittest.skip("Skipped!"), "TestCommon", "test_noncontiguous_samples"), | ||
| # following 2 tests failed intermittenly | ||
| DecorateInfo( |
There was a problem hiding this comment.
This is just formatting change to keep the line length rather than ignoring flake8 complaining about it (noqa: B950). The actual added xfail is the last one in this tuple.
Todo: - [ ] document this behavior - [x] add tests [ghstack-poisoned]
pmeier
commented
Feb 9, 2022
Todo: - [ ] document this behavior - [x] add tests [ghstack-poisoned]
Todo: - [ ] document this behavior - [x] add tests [ghstack-poisoned]
Todo: - [ ] document this behavior - [x] add tests [ghstack-poisoned]
ezyang
reviewed
Feb 16, 2022
| elif ( | ||
| op in float_only_ops | ||
| and (not dtypes[0].is_floating_point and not dtypes[0].is_complex) | ||
| and device != "meta" |
There was a problem hiding this comment.
This one also feels like it should still raise an error on meta.
ezyang
reviewed
Feb 16, 2022
| "TestCommon", | ||
| "test_out", | ||
| device_type="meta", | ||
| ), |
There was a problem hiding this comment.
This probably shouldn't fail
ezyang
reviewed
Feb 16, 2022
| "TestCommon", | ||
| "test_out", | ||
| device_type="meta", | ||
| ), |
There was a problem hiding this comment.
Ditto, this probably also shouldn't fail
ezyang
approved these changes
Feb 16, 2022
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: #72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104
|
Hey @pmeier. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
ezyang
added
release notes: composability
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 21, 2022
Summary: Pull Request resolved: pytorch/pytorch#72508 Todo: - [x] document this behavior - [x] add tests Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D34262452 Pulled By: ezyang fbshipit-source-id: bc5c9653d5c3ad5c6efccc9c8e0efc0d28e15104 (cherry picked from commit 233142c88e4cff02825c7e233aba9411a6df3e9f)
pmeier
added a commit
that referenced
this pull request
Dec 1, 2022
Two improvements here:
1. To render a bullet list correctly, a blank line before and after is needed. Compare
vs.
2. #72508 added proper support for meta tensors. Thus, we no longer throw an error if we encounter them.
[ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Dec 1, 2022
Two improvements here:
1. To render a bullet list correctly, a blank line before and after is needed. Compare
vs.
2. #72508 added proper support for meta tensors. Thus, we no longer throw an error if we encounter them.
[ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 1, 2022
Two improvements here:
1. To render a bullet list correctly, a blank line before and after is needed. Compare
vs.
2. #72508 added proper support for meta tensors. Thus, we no longer throw an error if we encounter them.
Pull Request resolved: #89620
Approved by: https://github.com/kit1980
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Two improvements here:
1. To render a bullet list correctly, a blank line before and after is needed. Compare
vs.
2. pytorch#72508 added proper support for meta tensors. Thus, we no longer throw an error if we encounter them.
Pull Request resolved: pytorch#89620
Approved by: https://github.com/kit1980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Todo:
Differential Revision: D34262452