add android and ios folder to merge rule #73041

linbinyu · 2022-02-17T22:26:52Z

Opt-in android and ios folder for the new GHF workflow

pytorch-bot · 2022-02-17T22:26:55Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/96c7e76abcc2d34d5196771212e645164fb83a1b/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-arm64-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-arm64-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
macos-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3-smoke	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`, `ciflow/xla`	🚫 skipped
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/trunk`, `ciflow/win`	🚫 skipped

facebook-github-bot · 2022-02-17T22:26:57Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/73041
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 00ef748 (more details on the Dr. CI page):

2/3 failures introduced in this PR
1/3 broken upstream at merge base 1522912 since Feb 17

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-bionic-rocm4.5-py3.7 / test (smoke_tests, 1, 1, linux.rocm.gpu) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-02-18T01:39:56.2545062Z FAIL [0.013s]: test_reduce_add_coalesced (__main__.TestCudaComm)

2022-02-18T01:39:56.1934975Z   test_scatter_cpu_dim (__main__.TestCudaComm) ... ok (0.008s)
2022-02-18T01:39:56.2016690Z   test_scatter_cpu_neg_dim (__main__.TestCudaComm) ... ok (0.008s)
2022-02-18T01:39:56.2109234Z   test_scatter_cpu_sizes (__main__.TestCudaComm) ... ok (0.009s)
2022-02-18T01:39:56.2195050Z   test_scatter_gpu (__main__.TestCudaComm) ... ok (0.008s)
2022-02-18T01:39:56.2281145Z   test_scatter_gpu_dim (__main__.TestCudaComm) ... ok (0.008s)
2022-02-18T01:39:56.2367915Z   test_scatter_gpu_neg_dim (__main__.TestCudaComm) ... ok (0.009s)
2022-02-18T01:39:56.2464337Z   test_scatter_gpu_sizes (__main__.TestCudaComm) ... ok (0.010s)
2022-02-18T01:39:56.2543717Z   test_scatter_namedtuple (__main__.TestCudaComm) ... ok (0.008s)
2022-02-18T01:39:56.2544200Z 
2022-02-18T01:39:56.2544419Z ======================================================================
2022-02-18T01:39:56.2545062Z FAIL [0.013s]: test_reduce_add_coalesced (__main__.TestCudaComm)
2022-02-18T01:39:56.2546523Z ----------------------------------------------------------------------
2022-02-18T01:39:56.2547218Z Traceback (most recent call last):
2022-02-18T01:39:56.2547847Z   File "test_cuda.py", line 3977, in test_reduce_add_coalesced
2022-02-18T01:39:56.2548563Z     self._test_reduce_add_coalesced(tensors, num_bytes * 5 // 2)
2022-02-18T01:39:56.2551944Z   File "test_cuda.py", line 3943, in _test_reduce_add_coalesced
2022-02-18T01:39:56.2553005Z     self.assertEqual(r, t * 2)
2022-02-18T01:39:56.2554753Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2145, in assertEqual
2022-02-18T01:39:56.2555813Z     msg=msg,
2022-02-18T01:39:56.2557179Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1064, in assert_equal
2022-02-18T01:39:56.2558409Z     raise error_metas[0].to_error()

win-vs2019-cuda11.3-py3-smoke / test (distributed, 1, 1, windows.8xlarge.nvidia.gpu) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-02-18T03:22:38.4930251Z RuntimeError: test_quantization failed!

2022-02-18T03:22:37.4031707Z   File "C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\build\torch\_tensor_str.py", line 135, in __init__
2022-02-18T03:22:37.4033320Z     value_str = ('{{:.{}e}}').format(PRINT_OPTS.precision).format(value)
2022-02-18T03:22:37.4034311Z   File "C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\build\torch\_tensor.py", line 627, in __format__
2022-02-18T03:22:37.4035125Z     return self.item().__format__(format_spec)
2022-02-18T03:22:37.4035657Z KeyboardInterrupt
2022-02-18T03:22:38.4927153Z Traceback (most recent call last):
2022-02-18T03:22:38.4928073Z   File "run_test.py", line 1098, in <module>
2022-02-18T03:22:38.4928547Z     main()
2022-02-18T03:22:38.4929053Z   File "run_test.py", line 1076, in main
2022-02-18T03:22:38.4929647Z     raise RuntimeError(err_message)
2022-02-18T03:22:38.4930251Z RuntimeError: test_quantization failed!
2022-02-18T03:22:38.8757438Z Terminate batch job (Y/N)? 
2022-02-18T03:22:38.8759100Z 
2022-02-18T03:22:38.8759839Z (base) C:\actions-runner\_work\pytorch\pytorch\test>popd
2022-02-18T03:22:38.8766768Z 
2022-02-18T03:22:38.8767657Z (base) C:\actions-runner\_work\pytorch\pytorch>if ERRORLEVEL 1 exit /b 1 
2022-02-18T03:22:38.8802135Z + cleanup
2022-02-18T03:22:38.8802598Z + retcode=1
2022-02-18T03:22:38.8802935Z + set +x
2022-02-18T03:22:38.8870136Z ##[error]The action has timed out.
2022-02-18T03:22:38.9332408Z ##[group]Run # -ir => recursive include all files in pattern

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.

linux-xenial-py3.7-clang7-asan / test (smoke_tests, 1, 1, linux.2xlarge) since Feb 17 (2cd0667)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2022-02-17T22:58:47Z

@linbinyu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

malfet · 2022-02-17T23:23:05Z

@pytorchbot merge this

linbinyu · 2022-02-17T23:23:21Z

@pytorchmergebot merge this

pytorchmergebot · 2022-02-17T23:24:42Z

Can't merge closed PR #73041

github-actions · 2022-02-17T23:25:04Z

Hey @linbinyu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Opt-in android and ios folder for the new GHF workflow Pull Request resolved: #73041 Test Plan: automation Reviewed By: malfet, seemethere Differential Revision: D34320858 fbshipit-source-id: d0a7405636809dc6eff41e7fde7ed5cb1fbcc43c

Opt-in android and ios folder for the new GHF workflow Pull Request resolved: pytorch/pytorch#73041

add android and ios folder to merge rule

96c7e76

Opt-in android and ios folder for the new GHF workflow

linbinyu requested review from atalman, janeyx99 and seemethere as code owners February 17, 2022 22:26

pytorch-bot bot added the ciflow/default label Feb 17, 2022

facebook-github-bot added the cla signed label Feb 17, 2022

linbinyu requested review from kit1980 and malfet February 17, 2022 22:28

Update merge_rules.json

00ef748

kit1980 approved these changes Feb 17, 2022

View reviewed changes

malfet approved these changes Feb 17, 2022

View reviewed changes

pytorchmergebot closed this in 4d642d0 Feb 17, 2022

malfet deleted the linbinyu-patch-2 branch February 18, 2022 01:34

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 21, 2022

add android and ios folder to merge rule

8fa1d1a

Opt-in android and ios folder for the new GHF workflow Pull Request resolved: pytorch/pytorch#73041

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 3, 2022

add android and ios folder to merge rule

6211c3d

Opt-in android and ios folder for the new GHF workflow Pull Request resolved: pytorch/pytorch#73041

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 3, 2022

add android and ios folder to merge rule

83499c7

Opt-in android and ios folder for the new GHF workflow Pull Request resolved: pytorch/pytorch#73041

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add android and ios folder to merge rule #73041

add android and ios folder to merge rule #73041

Uh oh!

linbinyu commented Feb 17, 2022

Uh oh!

pytorch-bot bot commented Feb 17, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 17, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Feb 17, 2022

Uh oh!

malfet commented Feb 17, 2022

Uh oh!

linbinyu commented Feb 17, 2022

Uh oh!

pytorchmergebot commented Feb 17, 2022

Uh oh!

github-actions bot commented Feb 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

add android and ios folder to merge rule #73041

add android and ios folder to merge rule #73041

Uh oh!

Conversation

linbinyu commented Feb 17, 2022

Uh oh!

pytorch-bot bot commented Feb 17, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

linux-bionic-rocm4.5-py3.7 / test (smoke_tests, 1, 1, linux.rocm.gpu) (1/2)

win-vs2019-cuda11.3-py3-smoke / test (distributed, 1, 1, windows.8xlarge.nvidia.gpu) (2/2)

🚧 1 ongoing upstream failure:

Uh oh!

facebook-github-bot commented Feb 17, 2022

Uh oh!

malfet commented Feb 17, 2022

Uh oh!

linbinyu commented Feb 17, 2022

Uh oh!

pytorchmergebot commented Feb 17, 2022

Uh oh!

github-actions bot commented Feb 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

facebook-github-bot commented Feb 17, 2022 •

edited

Loading