Squeeze p2: hook up Squeeze to LazyView #73067
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7f27ad1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
wconstab
reviewed
Feb 18, 2022
torch/csrc/lazy/core/lazy_view.cpp
Outdated
There was a problem hiding this comment.
in the backward pass of update we are undoing an operation, so for Squeeze we need to Unsqueeze and vice versa :)
Maybe I should've added Unsqueeze in the same PR. I just like small PRs !!
wconstab
approved these changes
Feb 18, 2022
|
@Krovatkin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Krovatkin
force-pushed
the
krovatkin/squeeze_lazyview
branch
from
0817fe1 to
7f27ad1
Compare
|
@Krovatkin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
Summary: This PR hooks up Squeeze op to LazyView. The end goal to reduce the instances where we need to rely on explicit shapes. In the final PR we will make `aten_ops` to use the right ViewInfo and update the lowering in ts_lowering. Pull Request resolved: #73067 Reviewed By: wconstab, mikaylagawarecki Differential Revision: D34345163 Pulled By: Krovatkin fbshipit-source-id: 6bfadedbded7521312019ead0dfc7c6a334ff0f5
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
Summary: This PR hooks up Squeeze op to LazyView. The end goal to reduce the instances where we need to rely on explicit shapes. In the final PR we will make `aten_ops` to use the right ViewInfo and update the lowering in ts_lowering. Pull Request resolved: pytorch/pytorch#73067 Reviewed By: wconstab, mikaylagawarecki Differential Revision: D34345163 Pulled By: Krovatkin fbshipit-source-id: 6bfadedbded7521312019ead0dfc7c6a334ff0f5 (cherry picked from commit 4b3b10fa97911c2302840b44b63619d081e0d9d4)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
Summary: This PR hooks up Squeeze op to LazyView. The end goal to reduce the instances where we need to rely on explicit shapes. In the final PR we will make `aten_ops` to use the right ViewInfo and update the lowering in ts_lowering. Pull Request resolved: pytorch/pytorch#73067 Reviewed By: wconstab, mikaylagawarecki Differential Revision: D34345163 Pulled By: Krovatkin fbshipit-source-id: 6bfadedbded7521312019ead0dfc7c6a334ff0f5 (cherry picked from commit 4b3b10fa97911c2302840b44b63619d081e0d9d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hooks up Squeeze op to LazyView.
The end goal to reduce the instances where we need to rely on explicit shapes.
In the final PR we will make
aten_opsto use the right ViewInfo and update the lowering in ts_lowering.