[codemod][type-comments] Convert type comments in api.py #73084
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I'm wrapping up the conversion of type comments to type annotations in caffe2. The last remaining "bulk" codemod has test failures that are hard for me to understand, so I'm going to submit PRs for each module individually which makes it easier to see what's causing problems. All the codemods were produced via LibCST and then manually cleaned up. Test Plan: Wait for github CI Differential Revision: D34344289 fbshipit-source-id: e5c2e137b04402f499b4657735f3b5ce4faa2e80
stroxler
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit badf002 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
|
This pull request was exported from Phabricator. Differential Revision: D34344289 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 19, 2022
Summary: Pull Request resolved: #73084 I'm wrapping up the conversion of type comments to type annotations in caffe2. The last remaining "bulk" codemod has test failures that are hard for me to understand, so I'm going to submit PRs for each module individually which makes it easier to see what's causing problems. All the codemods were produced via LibCST and then manually cleaned up. Test Plan: Wait for github CI Reviewed By: H-Huang Differential Revision: D34344289 fbshipit-source-id: e8e3a13c3d95f6804829f1818fb7f0605e5ba137
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 21, 2022
Summary: Pull Request resolved: pytorch/pytorch#73084 I'm wrapping up the conversion of type comments to type annotations in caffe2. The last remaining "bulk" codemod has test failures that are hard for me to understand, so I'm going to submit PRs for each module individually which makes it easier to see what's causing problems. All the codemods were produced via LibCST and then manually cleaned up. Test Plan: Wait for github CI Reviewed By: H-Huang Differential Revision: D34344289 fbshipit-source-id: e8e3a13c3d95f6804829f1818fb7f0605e5ba137 (cherry picked from commit 92d47d9cd549e85d002dd22e5f377356a3a98348)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#73084 I'm wrapping up the conversion of type comments to type annotations in caffe2. The last remaining "bulk" codemod has test failures that are hard for me to understand, so I'm going to submit PRs for each module individually which makes it easier to see what's causing problems. All the codemods were produced via LibCST and then manually cleaned up. Test Plan: Wait for github CI Reviewed By: H-Huang Differential Revision: D34344289 fbshipit-source-id: e8e3a13c3d95f6804829f1818fb7f0605e5ba137 (cherry picked from commit 92d47d9cd549e85d002dd22e5f377356a3a98348)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#73084 I'm wrapping up the conversion of type comments to type annotations in caffe2. The last remaining "bulk" codemod has test failures that are hard for me to understand, so I'm going to submit PRs for each module individually which makes it easier to see what's causing problems. All the codemods were produced via LibCST and then manually cleaned up. Test Plan: Wait for github CI Reviewed By: H-Huang Differential Revision: D34344289 fbshipit-source-id: e8e3a13c3d95f6804829f1818fb7f0605e5ba137 (cherry picked from commit 92d47d9cd549e85d002dd22e5f377356a3a98348)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm wrapping up the conversion of type comments to type annotations
in caffe2. The last remaining "bulk" codemod has test failures that
are hard for me to understand, so I'm going to submit PRs for each
module individually which makes it easier to see what's causing
problems.
All the codemods were produced via LibCST and then manually cleaned up.
Test Plan: Wait for github CI
Differential Revision: D34344289