GHF: Add clickable usernames for Approved / Reverted By #73677

seemethere · 2022-03-02T18:49:43Z

Stack from ghstack:

-> GHF: Add clickable usernames for Approved / Reverted By #73677

Should make the usernames clickable in the Github UI

Signed-off-by: Eli Uriegas eliuriegas@fb.com

Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]

pytorch-bot · 2022-03-02T18:49:47Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/4015052344885dfb2692f5d1d8af8429820d0a21/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4-mobile-lightweight-dispatch-build	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-arm64-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-arm64-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
macos-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.3-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`, `ciflow/xla`	🚫 skipped

facebook-github-bot · 2022-03-02T18:49:49Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/73677
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 94e8d26 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

1/1 broken upstream at merge base 7adc76a on Mar 02 from 10:15am to 10:49am

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

linux-xenial-py3.7-clang7-asan / test (default, 1, 3, linux.2xlarge) on Mar 02 from 10:15am to 10:49am (a5f2e59 - bbf4bc9)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

malfet

I don't think we should do it, as it will notify the person when commit is landed, cherry-picked or copied into the fork

seemethere · 2022-03-02T18:57:23Z

I wasn't thinking about the forked scenario, don't really want to be notified for people's forks

Should make the usernames clickable in the Github UI Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]

Adds clickable links within the Github UI for Approve By messages with Github First merges Signed-off-by: Eli Uriegas <eliuriegasfb.com> ghstack-source-id: f79f89e Pull Request resolved: #73677 Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

seemethere · 2022-03-02T19:07:17Z

Tested that this approach doesn't generate new notifications with this commit: seemethere/test-repo@dd4f218

Should make the usernames clickable in the Github UI Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]

malfet

Looks good to me, but can you please make similar change to "Reverted on behalf of"?

Should make the usernames clickable in the Github UI Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]

Adds clickable links within the Github UI for Approve By messages with Github First merges Signed-off-by: Eli Uriegas <eliuriegasfb.com> ghstack-source-id: b620903 Pull Request resolved: #73677 Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

seemethere · 2022-03-02T22:03:16Z

Looks good to me, but can you please make similar change to "Reverted on behalf of"?

Done

seemethere · 2022-03-03T22:57:31Z

@pytorchbot merge this

github-actions · 2022-03-03T22:59:20Z

Hey @seemethere.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Adds clickable links within the Github UI for Approve By messages with Github First merges Signed-off-by: Eli Uriegas <eliuriegasfb.com> Pull Request resolved: #73677 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Approved by: malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0b79715d49 Reviewed By: osalpekar Differential Revision: D34629143 fbshipit-source-id: 418e802848519054589c67de08444d8d41bad458

Adds clickable links within the Github UI for Approve By messages with Github First merges Signed-off-by: Eli Uriegas <eliuriegasfb.com> Pull Request resolved: pytorch/pytorch#73677 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Approved by: malfet

GHF: Add @ to usernames for Approved By

4015052

Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]

seemethere requested review from atalman and janeyx99 as code owners March 2, 2022 18:49

pytorch-bot bot added the ciflow/default label Mar 2, 2022

facebook-github-bot added the cla signed label Mar 2, 2022

seemethere requested a review from a team March 2, 2022 18:50

malfet requested changes Mar 2, 2022

View reviewed changes

seemethere closed this Mar 2, 2022

seemethere reopened this Mar 2, 2022

Update on "GHF: Add @ to usernames for Approved By"

8deeb56

Should make the usernames clickable in the Github UI Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]

seemethere changed the title ~~GHF: Add @ to usernames for Approved By~~ GHF: Add clickable usernames for Approved By Mar 2, 2022

Update on "GHF: Add clickable usernames for Approved By"

bc3f801

Should make the usernames clickable in the Github UI Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]

malfet approved these changes Mar 2, 2022

View reviewed changes

Update on "GHF: Add clickable usernames for Approved By"

94e8d26

Should make the usernames clickable in the Github UI Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]

seemethere changed the title ~~GHF: Add clickable usernames for Approved By~~ GHF: Add clickable usernames for Approved / Reverted By Mar 2, 2022

pytorchmergebot closed this in 0b79715 Mar 3, 2022

facebook-github-bot deleted the gh/seemethere/214/head branch March 7, 2022 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GHF: Add clickable usernames for Approved / Reverted By #73677

GHF: Add clickable usernames for Approved / Reverted By #73677

Uh oh!

seemethere commented Mar 2, 2022 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 2, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Mar 2, 2022 •

edited

Loading

Uh oh!

malfet left a comment

Uh oh!

seemethere commented Mar 2, 2022

Uh oh!

seemethere commented Mar 2, 2022

Uh oh!

malfet left a comment

Uh oh!

seemethere commented Mar 2, 2022

Uh oh!

seemethere commented Mar 3, 2022

Uh oh!

github-actions bot commented Mar 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GHF: Add clickable usernames for Approved / Reverted By #73677

GHF: Add clickable usernames for Approved / Reverted By #73677

Uh oh!

Conversation

seemethere commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 2, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🚧 1 fixed upstream failure:

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

seemethere commented Mar 2, 2022

Uh oh!

seemethere commented Mar 2, 2022

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

seemethere commented Mar 2, 2022

Uh oh!

seemethere commented Mar 3, 2022

Uh oh!

github-actions bot commented Mar 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

seemethere commented Mar 2, 2022 •

edited

Loading

facebook-github-bot commented Mar 2, 2022 •

edited

Loading