Adding gpuAtomicMin and gpuAtomicMax for floating types #74225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8b6e709 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced Mar 15, 2022
mikaylagawarecki
changed the title
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
cpuhrsch
reviewed
Mar 17, 2022
cpuhrsch
reviewed
Mar 17, 2022
| a[i] = 2; | ||
| sum[i] = 2; | ||
| answer[i] = pow(sum[i], static_cast<T>(factor)); | ||
| answer[i] = pow(sum[i], static_cast<T>(factor + 1)); |
There was a problem hiding this comment.
Is this fixing a preexisting bug?
There was a problem hiding this comment.
Yes, since there are factor threads where gpuAtomicMul(a[i], sum[i]) is done the final result should be 2^5 = 2^factor+1.
Are these tests run in CI? This was failing when I ran the test locally
There was a problem hiding this comment.
I'd suggest we open a separate issue and remove this change from this PR. This is some indication that these the tests aren't running / their signal is ignored.
There was a problem hiding this comment.
As discussed offline, this failure isn't detected in CI because cuda_atomic_ops_test is not in run_tests.sh, fixing in #74482
[ghstack-poisoned]
This was referenced Mar 23, 2022
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
@pytorchbot merge this please |
|
@pytorchbot merge this |
|
Hey @mikaylagawarecki. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: #74225 Approved by: https://github.com/ngimel Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/4025ca8cf457889672a68e13595b1ecc59a82b34 Reviewed By: malfet Differential Revision: D35118958 Pulled By: mikaylagawarecki fbshipit-source-id: 0d12e88149c3e378fa6c772245ee3e77b23274f2
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Pull Request resolved: #74225 Approved by: https://github.com/ngimel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack: