-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add Hpu to the rebuild component list #74738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hpu to the rebuild component list #74738
Conversation
Numpy array is chosen to be the rebuild component for HPU. so add it to the backend list. Signed-off-by: Ayman Yousef<ayousef@habana.ai> Signed-off-by: Jeeja <jeejakp@habana.ai>
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit f72a888 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Would it be possible to have a test for this? To make sure it works as expected and doesn't break in the future? |
@albanD the backend tests are in not in fork, for cpu or gpu this is not valid. any suggestion on where to add it. Below is the test that was reproducing the issue for hpu backend tensor(torch.save cause the problem) def example(rank, world_size, use_zero):
def main(): if name=="main": |
Well if there is no CI config that supports this, then this is ok. And your testing will handle it. |
@pytorchbot merge this please |
Hey @jeejakp12. |
Summary: Numpy array is chosen to be the rebuild component for HPU. so add it to the backend list. Signed-off-by: Ayman Yousef<ayousef@habana.ai> Signed-off-by: Jeeja <jeejakp@habana.ai> Fixes #ISSUE_NUMBER Pull Request resolved: #74738 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/88096253ef3f04f9a6211ce958d2401e925e5d2f Reviewed By: malfet, atalman Differential Revision: D35317405 fbshipit-source-id: daa87627ab0028b672591368715e22f06a942aa5
Numpy array is chosen to be the rebuild component for
HPU. so add it to the backend list.
Signed-off-by: Ayman Yousefayousef@habana.ai
Signed-off-by: Jeeja jeejakp@habana.ai
Fixes #ISSUE_NUMBER