Skip to content

Conversation

@NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Mar 29, 2022

This PR adds myself and @vmoens to the GHF superusers so that we can use the githubmergebot when working on torchhub PRs.

Stack from ghstack (oldest at bottom):

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 29, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 3309b17 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build pull / win-vs2019-cuda11.3-py3 / build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T09:23:03.6538677Z CMake Error: Error...ariable not set, cmake may not be built correctly.
2022-03-30T09:23:03.2502486Z CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
2022-03-30T09:23:03.2637307Z CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
2022-03-30T09:23:03.2637856Z Missing variable is:
2022-03-30T09:23:03.2638261Z CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
2022-03-30T09:23:03.2745207Z CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
2022-03-30T09:23:03.2745751Z Missing variable is:
2022-03-30T09:23:03.2746291Z CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
2022-03-30T09:23:03.2798793Z CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
2022-03-30T09:23:03.2799351Z Missing variable is:
2022-03-30T09:23:03.2799734Z CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
2022-03-30T09:23:03.6538677Z CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
2022-03-30T09:23:03.6539273Z Missing variable is:
2022-03-30T09:23:03.6539685Z CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
2022-03-30T09:23:03.8031598Z -- Generating done
2022-03-30T09:23:03.9286176Z CMake Warning:
2022-03-30T09:23:03.9286826Z   Manually-specified variables were not used by the project:
2022-03-30T09:23:03.9287201Z 
2022-03-30T09:23:03.9287507Z     BUILD_ENVIRONMENT
2022-03-30T09:23:03.9287825Z     BUILD_TYPE
2022-03-30T09:23:03.9288122Z     BUILD_WHEEL
2022-03-30T09:23:03.9288319Z 

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@NicolasHug NicolasHug changed the title Add torchhub devs to GHF superusers [GHF] Add torchhub devs to GHF superusers Mar 29, 2022
NicolasHug added a commit that referenced this pull request Mar 29, 2022
ghstack-source-id: bb1ebaf
Pull Request resolved: #74903
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere
Copy link
Member

@pytorchbot merge this

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 60b85558842845ec750049b6a8c1b3455ababb7c returned non-zero exit code 1
Auto-merging .github/merge_rules.json
CONFLICT (content): Merge conflict in .github/merge_rules.json
error: could not apply 60b8555... Add torchhub devs to GHF superusers
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Raised by https://github.com/pytorch/pytorch/actions/runs/2060125156

@seemethere
Copy link
Member

Looks like this might need to be rebased

This PR adds myself and vmoens to the GHF superusers so that we can use the githubmergebot when working on torchhub PRs.




[ghstack-poisoned]
NicolasHug added a commit that referenced this pull request Mar 30, 2022
ghstack-source-id: a0afcc2
Pull Request resolved: #74903
@NicolasHug
Copy link
Member Author

@pytorchbot merge this

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check Lint failed for rule OSS CI
Raised by https://github.com/pytorch/pytorch/actions/runs/2063771488

@NicolasHug
Copy link
Member Author

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @NicolasHug.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Mar 31, 2022
Summary:
Pull Request resolved: #74903

Approved by: https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/5fcc867a40a90b28cf0b92119a5ea1d18fe82dba

Reviewed By: atalman

Differential Revision: D35257340

Pulled By: NicolasHug

fbshipit-source-id: d0bff64fb98efde1d3216226d4319e672f591f40
@facebook-github-bot facebook-github-bot deleted the gh/NicolasHug/12/head branch April 2, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants