Skip to content

Pin cmake on windows #74954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Pin cmake on windows #74954

wants to merge 1 commit into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Mar 30, 2022 •
edited
Loading

Quick fix to rectify trunk health.

Broken jobs look like: https://github.com/pytorch/pytorch/runs/5751970985?check_suite_focus=true
Previously successful job uses version 3.22.3: https://github.com/pytorch/pytorch/runs/5746840621?check_suite_focus=true

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit df1cc58 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@janeyx99 janeyx99 requested a review from a team March 30, 2022 14:06
atalman
atalman approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this the only place ? Do we have some references in builder ?

@zengk95 zengk95 mentioned this pull request Mar 30, 2022
Closed
@janeyx99
Copy link
Contributor Author

@pytorchbot merge this pls!

@janeyx99
Copy link
Contributor Author

LGTM, is this the only place ? Do we have some references in builder ?

Good point, checking.

@github-actions
Copy link
Contributor

Hey @janeyx99.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Mar 31, 2022
@janeyx99 @facebook-github-bot
Pin cmake on windows (#74954)
7f284ad 
Summary:
Quick fix to rectify trunk health.

Broken jobs look like: https://github.com/pytorch/pytorch/runs/5751970985?check_suite_focus=true
Previously successful job uses version 3.22.3: https://github.com/pytorch/pytorch/runs/5746840621?check_suite_focus=true

Pull Request resolved: #74954
Approved by: https://github.com/atalman

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1e37c2084462582bf31862d34cb593fd5645f8b7

Reviewed By: atalman

Differential Revision: D35257347

Pulled By: janeyx99

fbshipit-source-id: 7aec7ff05148a65fa68e1843f5985f29a993ed72
@zengk95 zengk95 mentioned this pull request Mar 31, 2022
Closed
@janeyx99 janeyx99 mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janeyx99 @facebook-github-bot @atalman