-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Pin cmake version to workaround pytorch build issues #75045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b4bb92c (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
| Job | Step | Action |
|---|---|---|
| Checkout PyTorch | 🔁 rerun | |
| Unknown | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
| conda install -y numpy requests ninja pyyaml mkl mkl-include setuptools cmake cffi typing_extensions \ | ||
| # pin cmake version to 3.22 since 3.23 breaks pytorch build | ||
| # see details at: https://github.com/pytorch/pytorch/issues/74985 | ||
| conda install -y numpy requests ninja pyyaml mkl mkl-include setuptools cmake=3.22 cffi typing_extensions \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a good follow up to this would be to just pin all of these particular dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One problem of doing that is we need to keep consistent with pytorch/benchmark workflows such as in https://github.com/pytorch/benchmark/blob/main/.github/workflows/v2-bisection.yml#L31. Perhaps it is better to create a script in pytorch/benchmark to manage these dependencies in a unified manner.
|
@pytorchbot merge this |
|
Hey @xuzhao9. |
Summary: We need to pin the cmake version to workaround pytorch build issue. See details at: #74985 Pull Request resolved: #75045 Approved by: https://github.com/seemethere Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/62c6801edcc5362f68d7e8edf4ee1f14de424351 Reviewed By: atalman Differential Revision: D35317406 Pulled By: xuzhao9 fbshipit-source-id: b1e69e8ce418374c17fb56a3a6c3a6a93a692b7b
We need to pin the cmake version to workaround pytorch build issue.
See details at: #74985