Skip to content

Conversation

kennyhorror
Copy link
Contributor

Summary:
At the moment if jit.trace is failing on unsupported return types, it's going
to be super hard to find exact operator that is causing trobules for fixing
this.

This diff improves logging to include operator name in additiona to the failed
type.

Test Plan:
Tested on one of the failed models. See which exact operator is causing
troubles.

Differential Revision: D35302222

Summary:
At the moment if jit.trace is failing on unsupported return types, it's going
to be super hard to find exact operator that is causing trobules for fixing
this.

This diff improves logging to include operator name in additiona to the failed
type.

Test Plan:
Tested on one of the failed models. See which exact operator is causing
troubles.

Differential Revision: D35302222

fbshipit-source-id: cd1beff361fc8415d7725fe725ad002e0ad404c6
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 1, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 784b3f8 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D35302222

facebook-github-bot pushed a commit that referenced this pull request Apr 1, 2022
Summary:
Pull Request resolved: #75056

At the moment if jit.trace is failing on unsupported return types, it's going
to be super hard to find exact operator that is causing trobules for fixing
this.

This diff improves logging to include operator name in additiona to the failed
type.

Test Plan:
Tested on one of the failed models. See which exact operator is causing
troubles.

Differential Revision: D35302222

fbshipit-source-id: 64fc4c850e226c16c435c0951215df4e634f23b5
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Hey @kennyhorror.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants