Fix sign-compare violations in python_list.h #75076
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`idx` is signed type as well as `len()`, so no need to cast one of the two two unsigned. Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5427145 (more details on the Dr. CI page):
🕵️♀️ 1 failure not recognized by patterns:The following CI failures may be due to changes from the PR
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 1, 2022
Closed
facebook-github-bot
added
the
oncall: jit
This was referenced Apr 1, 2022
malfet
requested review from
a team,
albanD and
b0noI
and removed request for
a team
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
Summary: `idx` is signed type as well as `len()`, so no need to cast one of the two two unsigned. Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo Pull Request resolved: #75076 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9bb12beda14197c03e347dc0d959ae192730f547 Reviewed By: atalman Differential Revision: D35359969 Pulled By: malfet fbshipit-source-id: aa9f40d893c501d2a19b554c730399a848bf6d3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
-Wsign-compareto list of clang flags #75085c10d/Utils.hpp#75081idxis signed type as well aslen(), so no need to cast one of thetwo two unsigned.
Prerequisite change for enabling
-Werror=sign-compareacross PyTorch repo