-
Notifications
You must be signed in to change notification settings - Fork 25.7k
updated _forward_unim. to include descriptive error #75148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @zikpefu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7838f1c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
@pytorchbot merge this please |
|
Hey @zikpefu. |
|
Hey @albanD are there examples where I can get the release notes so that it doesn't get closed again? Thanks! |
|
Hey! So this PR was merged and all is good! Thanks for taking the time to send it! |
|
Ah I understand. Thanks for taking a look at it I appreciate it! |
Summary: Fixes #74303 Added error description for an unimplemented forward function. _Using torch summary to test the functionality_ Before:  After:  Pull Request resolved: #75148 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/43cc726c228c62329fd4f6fe51623288686a6ab2 Reviewed By: b0noI Differential Revision: D35510882 fbshipit-source-id: 1c78beb22052eb77670a001ac849b77c87640000
Fixes #74303
Added error description for an unimplemented forward function.
Using torch summary to test the functionality

Before:
After:
