Skip to content

Conversation

@zikpefu
Copy link
Contributor

@zikpefu zikpefu commented Apr 2, 2022

Fixes #74303

Added error description for an unimplemented forward function.

Using torch summary to test the functionality
Before:
image

After:
image

@facebook-github-bot
Copy link
Contributor

Hi @zikpefu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 2, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 7838f1c (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@mruberry mruberry added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 4, 2022
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@albanD
Copy link
Collaborator

albanD commented Apr 8, 2022

@pytorchbot merge this please

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hey @zikpefu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@albanD albanD added the topic: not user facing topic category label Apr 8, 2022
@zikpefu
Copy link
Contributor Author

zikpefu commented Apr 8, 2022

Hey @albanD are there examples where I can get the release notes so that it doesn't get closed again? Thanks!

@albanD
Copy link
Collaborator

albanD commented Apr 8, 2022

Hey!
Note that we don't use the github "merge" feature as we have a bit extra logic that runs. So our bot actually does the merge and closes the PR. This was commited in the main branch here: 43cc726

So this PR was merged and all is good! Thanks for taking the time to send it!

@zikpefu
Copy link
Contributor Author

zikpefu commented Apr 9, 2022

Ah I understand. Thanks for taking a look at it I appreciate it!

facebook-github-bot pushed a commit that referenced this pull request Apr 11, 2022
Summary:
Fixes #74303

Added error description for an unimplemented forward function.

_Using torch summary to test the functionality_
Before:
![image](https://user-images.githubusercontent.com/34219451/161395955-39947ea0-3664-41b6-9ed7-0af58c3c8901.png)

After:
![image](https://user-images.githubusercontent.com/34219451/161395910-71d2078d-268a-4b1f-88af-33dba6dff6a7.png)

Pull Request resolved: #75148
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/43cc726c228c62329fd4f6fe51623288686a6ab2

Reviewed By: b0noI

Differential Revision: D35510882

fbshipit-source-id: 1c78beb22052eb77670a001ac849b77c87640000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NotImplementedError Description

5 participants