Skip to content

[GHA] Add note about updating cached GQL queries #75229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 1 commit into from
Closed

[GHA] Add note about updating cached GQL queries #75229

wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Apr 4, 2022

Fixes #ISSUE_NUMBER

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 4, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 6277501 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

bigfootjon
bigfootjon approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@bigfootjon bigfootjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the test caught the HTTP Not Authorized exception and showed this as the error message to the user, but this change is sufficient as-is IMO

@malfet
Copy link
Contributor Author

malfet commented Apr 4, 2022

Updated to catch HTTP/401 error

@malfet malfet force-pushed the malfet/gha-add-note-to-tests branch from 9679394 to 6277501 Compare April 4, 2022 23:03
@malfet
Copy link
Contributor Author

malfet commented Apr 4, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
@malfet @facebook-github-bot
[GHA] Add note about updating cached GQL queries (#75229)
9ec09a3 
Summary:
Fixes #ISSUE_NUMBER

Pull Request resolved: #75229
Approved by: https://github.com/seemethere, https://github.com/bigfootjon

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/dd63658a2b5e7ecbf31cf092c1246d5d2f0306ed

Reviewed By: b0noI

Differential Revision: D35404305

Pulled By: malfet

fbshipit-source-id: 4ee8ed5250f3465cf21ff5611a63abc877499749
@malfet malfet deleted the malfet/gha-add-note-to-tests branch July 17, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@bigfootjon bigfootjon bigfootjon approved these changes

@janeyx99 janeyx99 Awaiting requested review from janeyx99

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @facebook-github-bot @seemethere @bigfootjon