[FSDP] Separate shared code into hooks #75424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All load_state_dict implementations call synchronize(), so put this into hook for preparation of doing all FSDP-specific state_dict loading logic in pre/post hooks. Differential Revision: [D35439351](https://our.internmc.facebook.com/intern/diff/D35439351/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
awgu,
mingzhe09088,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8e84c5d (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced Apr 7, 2022
All load_state_dict implementations call synchronize(), so put this into hook for preparation of doing all FSDP-specific state_dict loading logic in pre/post hooks. Differential Revision: [D35439351](https://our.internmc.facebook.com/intern/diff/D35439351/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 15, 2022
Pull Request resolved: #75424 All load_state_dict implementations call synchronize(), so put this into hook for preparation of doing all FSDP-specific state_dict loading logic in pre/post hooks. ghstack-source-id: 154042197 Differential Revision: [D35439351](https://our.internmc.facebook.com/intern/diff/D35439351/)
|
@pytorchbot merge this (Initiating merge automatically since Phabricator Diff has merged) |
|
Merge failed due to Matched rule superuser, but it was not reviewed yet by any of:kyulee-com,kausv,jackm321,erichan1,jingsh, ... |
malfet
approved these changes
Apr 18, 2022
|
@pytorchbot merge this |
|
Merge failed due to Matched rule superuser, but it was not reviewed yet by any of:kumpera,tvalentius,ZolotukhinM,xinyang0,ccongge, ... |
malfet
pushed a commit
that referenced
this pull request
Apr 18, 2022
Pull Request resolved: #75424 All load_state_dict implementations call synchronize(), so put this into hook for preparation of doing all FSDP-specific state_dict loading logic in pre/post hooks. ghstack-source-id: 154042197 Differential Revision: [D35439351](https://our.internmc.facebook.com/intern/diff/D35439351/)
|
Manually edited |
|
@pytorchbot merge this |
|
Hey @rohan-varma. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2022
Summary: Pull Request resolved: #75424 All load_state_dict implementations call synchronize(), so put this into hook for preparation of doing all FSDP-specific state_dict loading logic in pre/post hooks. ghstack-source-id: 154042197 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D35439351 fbshipit-source-id: 7236de6af9aaf2d91c4fe9d29b600a56b520897b
malfet
pushed a commit
that referenced
this pull request
Apr 20, 2022
Pull Request resolved: #75424 All load_state_dict implementations call synchronize(), so put this into hook for preparation of doing all FSDP-specific state_dict loading logic in pre/post hooks. Differential Revision: [D35439351](https://our.internmc.facebook.com/intern/diff/D35439351/) Approved by: https://github.com/awgu, https://github.com/zhaojuanmao, https://github.com/malfet (cherry picked from commit 9e864f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
All load_state_dict implementations call synchronize(), so put this into hook for preparation of doing all FSDP-specific state_dict loading logic in pre/post hooks.
Differential Revision: D35439351