[quant][improvement][gpu] Fixed errors in test_qlinear_cudnn #75446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8494350 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 7, 2022
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` Differential Revision: [D35473729](https://our.internmc.facebook.com/intern/diff/D35473729) [ghstack-poisoned]
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
dzdang
added
release notes: quantization
Summary: Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` Differential Revision: [D35473729](https://our.internmc.facebook.com/intern/diff/D35473729) [ghstack-poisoned]
Summary: Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` Differential Revision: [D35473729](https://our.internmc.facebook.com/intern/diff/D35473729) [ghstack-poisoned]
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` Differential Revision: [D35473729](https://our.internmc.facebook.com/intern/diff/D35473729) [ghstack-poisoned]
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
approved these changes
Apr 8, 2022
Summary: Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` Differential Revision: [D35473729](https://our.internmc.facebook.com/intern/diff/D35473729) [ghstack-poisoned]
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` Differential Revision: [D35473729](https://our.internmc.facebook.com/intern/diff/D35473729) [ghstack-poisoned]
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` Differential Revision: [D35473729](https://our.internmc.facebook.com/intern/diff/D35473729) [ghstack-poisoned]
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@pytorchbot merge this (Initiating merge automatically since Phabricator Diff has merged) |
|
@pytorchbot merge this (Initiating merge automatically since Phabricator Diff has merged) |
|
Can't merge closed PR #75446 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 16, 2022
Summary: Pull Request resolved: #75446 Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test Plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` Differential Revision: D35473729 D35473729 Reviewed By: ezyang Pulled By: dzdang fbshipit-source-id: 8911752565004ba4ae5fbf1ab3ce53b48b4dc1cb
malfet
pushed a commit
that referenced
this pull request
Apr 20, 2022
Summary: Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu are now enabled. Test plan: ``` python test/test_quantization.py TestQuantizedLinear.test_qlinear_cudnn ``` Pull Request resolved: #75446 Approved by: https://github.com/jerryzh168 (cherry picked from commit 7d8b366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Previously, test_qlinear_cudnn had some hard coded parameters that are now removed, and bias and relu
are now enabled.
Test plan:
Differential Revision: D35473729