-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Attempt to run tests from root repo #75608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit bf06e8d (more details on the Dr. CI page):
🕵️ 23 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
Mitigates #56396 The true fix would be #75608 but there are many issues to debug and this is a good step forward to at least clarify. Pull Request resolved: #75620 Approved by: https://github.com/kit1980, https://github.com/seemethere, https://github.com/malfet
Summary: Mitigates #56396 The true fix would be #75608 but there are many issues to debug and this is a good step forward to at least clarify. Pull Request resolved: #75620 Approved by: https://github.com/kit1980, https://github.com/seemethere, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8d3e3ebc583eb3a4ca230fa41f06d8ef5d453d63 Reviewed By: mehtanirav Differential Revision: D35582767 Pulled By: janeyx99 fbshipit-source-id: fbc433ee064b0bb02adb8673cf99573e910f9850
|
Closing, documented errors instead in COTNRIBUTING.md |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
| # Can't call `python -m unittest test_*` here because it doesn't run code | ||
| # in `if __name__ == '__main__': `. So call `python test_*.py` instead. | ||
| argv = [test_module + ".py"] + unittest_args | ||
| argv = [test_directory + "/" + test_module + ".py"] + unittest_args |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to use os.path.join(test_directory, test_module + ".py") here... Or may be an f-string
Fixes #56396