Skip to content

[SR][easy] Fix README diagram #75670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SR][easy] Fix README diagram #75670

wants to merge 1 commit into from

Conversation

@mikeiovine
Copy link

@mikeiovine mikeiovine commented Apr 12, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Rendering this got messed up, fixed by encosing in backticks

Differential Revision: D35581875

[SR][easy] Fix README diagram
c71eb84 
Rendering this got messed up, fixed by encosing in backticks

Differential Revision: [D35581875](https://our.internmc.facebook.com/intern/diff/D35581875/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 12, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit c71eb84 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Apr 12, 2022
mikeiovine pushed a commit that referenced this pull request Apr 12, 2022
[SR][easy] Fix README diagram
cc46ed7 
Rendering this got messed up, fixed by encosing in backticks

Differential Revision: [D35581875](https://our.internmc.facebook.com/intern/diff/D35581875/)

ghstack-source-id: 153668480
Pull Request resolved: #75670
@tenpercent tenpercent self-requested a review April 13, 2022 21:46
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

@github-actions
Copy link
Contributor

Hey @mikeiovine.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 14, 2022
@facebook-github-bot
[SR][easy] Fix README diagram (#75670)
680fb41 
Summary:
Pull Request resolved: #75670

Rendering this got messed up, fixed by encosing in backticks
ghstack-source-id: 153668480

Test Plan: Markdown preview

Reviewed By: tenpercent

Differential Revision: D35581875

fbshipit-source-id: 2f1ab1dc055bc8091668f9a26a09f50149280b7d
@facebook-github-bot facebook-github-bot deleted the gh/mikeiovine/57/head branch April 17, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenpercent tenpercent tenpercent approved these changes

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikeiovine @facebook-github-bot @tenpercent