Skip to content

Move //xplat/caffe2:caffe2_serialize to shared build structure #75847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move //xplat/caffe2:caffe2_serialize to shared build structure #75847

wants to merge 1 commit into from

Conversation

@kit1980
Copy link
Contributor

@kit1980 kit1980 commented Apr 14, 2022

Summary: This is a first step to migrate xplat targets to shared build structure. Eventually both xplat buck and open source bazel targets will be generated from shared build.bzl.

Test Plan: Should be no-op, rely on CI.

Reviewed By: malfet

Differential Revision: D35270004

@kit1980 @facebook-github-bot
Move //xplat/caffe2:caffe2_serialize to shared build structure
0498665 
Summary: This is a first step to migrate xplat targets to shared build structure. Eventually both xplat buck and open source bazel targets will be generated from shared build.bzl.

Test Plan: Should be no-op, rely on CI.

Reviewed By: malfet

Differential Revision: D35270004

fbshipit-source-id: a8971bc764a183c0193cd666c8df132f32312fcb
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 14, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 0498665 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D35270004

@kit1980 kit1980 requested review from linbinyu and malfet April 14, 2022 22:12
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

@github-actions
Copy link
Contributor

Hey @kit1980.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 15, 2022
@kit1980 @facebook-github-bot
Move //xplat/caffe2:caffe2_serialize to shared build structure (#75847)
7d4dda3 
Summary:
Pull Request resolved: #75847

This is a first step to migrate xplat targets to shared build structure. Eventually both xplat buck and open source bazel targets will be generated from shared build.bzl.

Test Plan: Should be no-op, rely on CI.

Reviewed By: malfet, linbinyu

Differential Revision: D35270004

fbshipit-source-id: bccd9dae0bc680cea6e35bbb253f2ca2954668bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linbinyu linbinyu linbinyu approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

cla signed fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kit1980 @facebook-github-bot @linbinyu