Exclude mobile TorchScript models from linter checks #75906
Conversation
[ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7eabcad (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
When `lintrunner` is run on the whole repository, files are found using `grep` with the `-I` flag to exclude binary files. However, when it's run on a diff, it doesn't filter out binary files and runs into unexpected errors such as this CI run: https://github.com/pytorch/pytorch/runs/6041884681 [ghstack-poisoned]
|
@pytorchbot merge this |
|
Hey @peterbell10. |
Summary: Pull Request resolved: #75906 Approved by: https://github.com/suo Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/702c7f00e2b5a425dbc03f88354a35a0cf7fd0d6 Reviewed By: mehtanirav Differential Revision: D35721646 fbshipit-source-id: 73acf2bb5d45bec8c587e18f6fb9797a7325045c
Pull Request resolved: #75906 Approved by: https://github.com/suo (cherry picked from commit 702c7f0)
4 participants
Stack from ghstack (oldest at bottom):
When
lintrunneris run on the whole repository, files are found usinggrepwith the-Iflag to exclude binary files. However, when it's run on a diff, it doesn't filter out binary files and runs into unexpected errors such as this CI run:https://github.com/pytorch/pytorch/runs/6041884681