[lint] fix spurious annotations on formatting linters #75928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would for some reason report formatting-based lints as showing up at line 1 column 1. This removes them for now. Maybe eventually we can recover better line numbers from the formatting diff and post messages for each diff cluster, but that requires actual changes to the linting engine. [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b15633d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
We would for some reason report formatting-based lints as showing up at line 1 column 1. This removes them for now. Maybe eventually we can recover better line numbers from the formatting diff and post messages for each diff cluster, but that requires actual changes to the linting engine. [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 15, 2022
We would for some reason report formatting-based lints as showing up at line 1 column 1. This removes them for now. Maybe eventually we can recover better line numbers from the formatting diff and post messages for each diff cluster, but that requires actual changes to the linting engine. ghstack-source-id: eb6eb5b Pull Request resolved: #75928
janeyx99
approved these changes
Apr 16, 2022
|
@pytorchbot merge this |
|
Hey @suo. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2022
Summary: We would for some reason report formatting-based lints as showing up at line 1 column 1. This removes them for now. Maybe eventually we can recover better line numbers from the formatting diff and post messages for each diff cluster, but that requires actual changes to the linting engine. Pull Request resolved: #75928 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d8374efb530d02d9696bae8947f0000e903b6a36 Reviewed By: mehtanirav Differential Revision: D35721649 Pulled By: suo fbshipit-source-id: ad7b6c9855f3cf3638788f76ae8f41a712c7c416
malfet
pushed a commit
that referenced
this pull request
Apr 20, 2022
We would for some reason report formatting-based lints as showing up at line 1 column 1. This removes them for now. Maybe eventually we can recover better line numbers from the formatting diff and post messages for each diff cluster, but that requires actual changes to the linting engine. Pull Request resolved: #75928 Approved by: https://github.com/janeyx99 (cherry picked from commit d8374ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We would for some reason report formatting-based lints as showing up at
line 1 column 1. This removes them for now. Maybe eventually we can
recover better line numbers from the formatting diff and post messages
for each diff cluster, but that requires actual changes to the linting
engine.