-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Add back SHARD_NUMBER and TEST_CONFIG to upload test stats step #75989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back SHARD_NUMBER and TEST_CONFIG to upload test stats step #75989
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 14b70ac (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
|
@clee2000 Do you think this would differentiate them enough to pull more the right summaries? |
|
@pytorchbot merge this pls! |
|
Hey @janeyx99. |
Summary: These are used in the print_test_stats file and somehow are no longer passed. Pull Request resolved: #75989 Approved by: https://github.com/clee2000 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/86ea57805b53141456d5dec2b36f0a3fa94dc636 Test plan from GitHub: After CI runs, check the S3 to make sure the file names include shard number and config. Reviewed By: seemethere Differential Revision: D35751466 Pulled By: janeyx99 fbshipit-source-id: 25d543692270f2f5f60fdfffc37c7603cc1ff3cb
These are used in the print_test_stats file and somehow are no longer passed. Test plan: After CI runs, check the S3 to make sure the file names include shard number and config. Pull Request resolved: #75989 Approved by: https://github.com/clee2000 (cherry picked from commit 86ea578)

These are used in the print_test_stats file and somehow are no longer passed.
Test plan:
After CI runs, check the S3 to make sure the file names include shard number and config.