Skip to content

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Apr 18, 2022

These are used in the print_test_stats file and somehow are no longer passed.

Test plan:
After CI runs, check the S3 to make sure the file names include shard number and config.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 18, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 14b70ac (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-04-18T21:39:34.5402117Z The PR is introduc...m to confirm whether this change is wanted or not.
2022-04-18T21:39:34.5389346Z processing existing schema:  text(__torch__.torch.classes.profiling.SourceRef _0) -> (str _0)
2022-04-18T21:39:34.5390734Z processing existing schema:  count(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-04-18T21:39:34.5393171Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-04-18T21:39:34.5394061Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> (__torch__.torch.classes.profiling.SourceRef _0)
2022-04-18T21:39:34.5395214Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> (Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0)
2022-04-18T21:39:34.5396154Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-04-18T21:39:34.5397420Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-04-18T21:39:34.5398601Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-04-18T21:39:34.5400512Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> (__torch__.torch.classes.profiling.SourceStats[] _0)
2022-04-18T21:39:34.5401473Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (NoneType _0)
2022-04-18T21:39:34.5402117Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-04-18T21:39:34.5402386Z 
2022-04-18T21:39:34.5402460Z Broken ops: [
2022-04-18T21:39:34.5402884Z 	aten::_validate_sparse_compressed_tensor_args(Tensor crow_indices, Tensor col_indices, Tensor values, int[] size, int layout) -> ()
2022-04-18T21:39:34.5403168Z ]
2022-04-18T21:39:34.6313046Z + cleanup
2022-04-18T21:39:34.6313279Z + retcode=1
2022-04-18T21:39:34.6313453Z + set +x
2022-04-18T21:39:34.6352973Z ##[error]Process completed with exit code 1.
2022-04-18T21:39:34.6393745Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-04-18T21:39:34.6393999Z with:

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@janeyx99 janeyx99 requested a review from clee2000 April 18, 2022 20:00
@janeyx99
Copy link
Contributor Author

@clee2000 Do you think this would differentiate them enough to pull more the right summaries?

@janeyx99
Copy link
Contributor Author

image

success!

@janeyx99
Copy link
Contributor Author

@pytorchbot merge this pls!

@github-actions
Copy link
Contributor

Hey @janeyx99.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 19, 2022
Summary:
These are used in the print_test_stats file and somehow are no longer passed.

Pull Request resolved: #75989
Approved by: https://github.com/clee2000

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/86ea57805b53141456d5dec2b36f0a3fa94dc636

Test plan from GitHub:
After CI runs, check the S3 to make sure the file names include shard number and config.

Reviewed By: seemethere

Differential Revision: D35751466

Pulled By: janeyx99

fbshipit-source-id: 25d543692270f2f5f60fdfffc37c7603cc1ff3cb
malfet pushed a commit that referenced this pull request Apr 20, 2022
These are used in the print_test_stats file and somehow are no longer passed.

Test plan:
After CI runs, check the S3 to make sure the file names include shard number and config.
Pull Request resolved: #75989
Approved by: https://github.com/clee2000

(cherry picked from commit 86ea578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants